Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with empty command line input #19

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

mahdemir
Copy link

I experienced an issue when i enter empty command in my zsh terminal on MacOS Ventura 12.7.1, it only happens after timer_show variable is already filled with some info, see picture..

Fixed it by resetting timer_show variable to empty string in "_cmd_time_precmd()".

cmd_time_err

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! We'll look at your PR soon.

@TomfromBerlin
Copy link
Owner

TomfromBerlin commented Jan 14, 2024

Hi Mahmut,
thank you for your contribution. I'm sorry I was late with my reply, but I had to address some real life issues and change my priorities accordingly.

Regarding to your contribution:
I also experienced the problem you described, but I wasn't smart enough to find this simple but elegant solution. So I ignored it since I wasn't really disturbed and I did not thought, that someone will be interested in this plugin, because there are so many similar and maybe better or more sophisticated solutions.

Thank you again for your effort.

Cheers
Tom

@TomfromBerlin TomfromBerlin merged commit d119b5f into TomfromBerlin:main Jan 14, 2024
1 check passed
Copy link
Owner

@TomfromBerlin TomfromBerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants