Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Dropwizard 3.x #15

Open
BastienDurel opened this issue May 23, 2023 · 7 comments
Open

Support for Dropwizard 3.x #15

BastienDurel opened this issue May 23, 2023 · 7 comments
Labels
needs more votes This issue will not be tackled until more people request it.

Comments

@BastienDurel
Copy link

Hello.

It would be nice if Dropwizard 3.x could be added. Only a few import/interface renames are needed. (dropwizard-websocket-jee7-bundle cannot be used as jetty version changed (and some base DW classes changed package))

I've done that on https://github.com/BastienDurel/dropwizard-websocket-jsr356-bundle/tree/dropwizard_3 (with only a version chnge, don't know if a new artifact name would be better)

@TomCools
Copy link
Owner

I could introduce a new 3.x branch for that to work! However; I'd like to motivate people to jump on the newer 4.x.
If this 3.x is requested by a few more people (by commenting here), then I'll do it. 👍

@YSavitski
Copy link

Hi @TomCools
Will be latest release 4.x available and accessible on the maven-central?
I may see that 2.1.6 is the last avaialble version

Thx in advacne

image

@TomCools
Copy link
Owner

TomCools commented Jun 1, 2023

Hi @TomCools Will be latest release 4.x available and accessible on the maven-central? I may see that 2.1.6 is the last avaialble version

Thx in advacne

image

I forgot to update the badge in the readme it seems. The 4.x release has been on Maven Central for a while, https://mvnrepository.com/artifact/be.tomcools/dropwizard-websocket-jsr356-bundle. Note the change in artifact name.

@YSavitski
Copy link

Hi @TomCools Will be latest release 4.x available and accessible on the maven-central? I may see that 2.1.6 is the last avaialble version
Thx in advacne
image

I forgot to update the badge in the readme it seems. The 4.x release has been on Maven Central for a while, https://mvnrepository.com/artifact/be.tomcools/dropwizard-websocket-jsr356-bundle. Note the change in artifact name.

Hi @TomCools
Thank you for hint with link !

@spags-lacework
Copy link

This would be awesome to have to make upgrading Dropwizard easier, as I could stage it from 2->3, then 3->4. In someways it would be better to go just from 2->4, but I'm trying simplify the number of libraries to upgrade.

@TomCools TomCools added the needs more votes This issue will not be tackled until more people request it. label Sep 12, 2024
@YSavitski
Copy link

Hey @TomCools
I'm fully with @spags-lacework . It would be great to have support of intermediate version 3.x.
We're going to upgrade our projects and may see that doing upgrade from 2.1.x to 4.x within the one step is too complex and might be dangerous

@YSavitski
Copy link

Hey @TomCools would it be possible to review my changes #19 ?
Many thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more votes This issue will not be tackled until more people request it.
Projects
None yet
Development

No branches or pull requests

4 participants