Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

AuthenticationConfirmationActivity dead code? #30

Open
SyntaxPolice opened this issue Jul 24, 2013 · 0 comments
Open

AuthenticationConfirmationActivity dead code? #30

SyntaxPolice opened this issue Jul 24, 2013 · 0 comments

Comments

@SyntaxPolice
Copy link
Contributor

Greetings,

The AuthenticationConfirmationActivity has the call only to _login commented out. This clearly means that these functions are dead code:
_login
_initChallengeResponse, which calls _requestSessionKey

Less obviously (due to inheritance) it looks like these functions are dead code:

onSessionKeyAvailable (this gets indirectly called by _requestSessionKey() which is dead?)
_authenticateAtServer
_parseResponse, etc.

This is the majority of code in the file and most of it's duplicated in:
AuthenticationPincodeActivity

Can you clarify which parts are dead by removing them?

Here's the code:

https://github.com/SURFnet/tiqr/blob/master/Android/MobileAuth/src/org/tiqr/authenticator/authentication/AuthenticationConfirmationActivity.java

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant