Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0 is using an old version of fff #954

Open
mmerlo opened this issue Nov 14, 2024 · 3 comments
Open

1.0.0 is using an old version of fff #954

mmerlo opened this issue Nov 14, 2024 · 3 comments
Labels
dependencies Pull requests that update a dependency file priority

Comments

@mmerlo
Copy link

mmerlo commented Nov 14, 2024

The latest 1.0.0 rc (1.0.0-f899db8) is using an older version of fff. The fff version appears to be v0.1.1, where as the latest version is v0.2.0. Since fff is now directly part of the ceedling repo instead of a submodule, it is difficult to tell exactly what version of fff is being used.

@dnguye86
Copy link

Suggest to update fff to latest version.

@mkarlesky mkarlesky added dependencies Pull requests that update a dependency file priority labels Nov 16, 2024
@mmerlo
Copy link
Author

mmerlo commented Nov 18, 2024

Adding for clarity - There are two related issues being reported here:

Issue 1: Version 1.0.0 (f899db8) is using an older version of fake_function_framework.
Issue 2: Previous versions of Ceedling (eg 0.31.1) imported the fake_function_framework as a submodule so determining the version/commit being used by Ceedling was straightforward. Version 1.0.0 is directly adding the fake function framework which makes it difficult to determine the version/commit being used. When the fake_function_framework is updated, I recommend adding a method for determining the fake_function_framework version being used in Ceedling.

@mvandervoord
Copy link
Member

Issue 1 has been resolved. Issue 2 is something we should definitely discuss further going forward. This is a general problem with tool versioning that should get some thought.

mkarlesky added a commit that referenced this issue Jan 1, 2025
TODO: Update the fff snapshot to version 0.2.0 (issue #954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file priority
Projects
None yet
Development

No branches or pull requests

4 participants