From d9ab7caf1d710b5d6f9afd2bd158a1380fded0bc Mon Sep 17 00:00:00 2001 From: Mark VanderVoord Date: Sun, 11 Feb 2024 21:32:29 -0500 Subject: [PATCH] Remove original module generator tests now that it's tested in the plugin. --- spec/spec_system_helper.rb | 189 --------------------------------- spec/system/deployment_spec.rb | 39 ------- 2 files changed, 228 deletions(-) diff --git a/spec/spec_system_helper.rb b/spec/spec_system_helper.rb index 31cecfe3..dde13f3d 100644 --- a/spec/spec_system_helper.rb +++ b/spec/spec_system_helper.rb @@ -3,20 +3,6 @@ require 'ceedling/yaml_wrapper' require 'spec_helper' -if Gem.ruby_version >= Gem::Version.new("2.5.0") - Modulegenerator = Struct.new(:project_root, :source_root, :inc_root, :test_root, keyword_init: true) do - def initialize(project_root: "./", source_root: "src/", inc_root: "src/", test_root: "test/") - super - end - end -else - Modulegenerator = Struct.new(:project_root, :source_root, :inc_root, :test_root) do - def initialize(project_root: "./", source_root: "src/", inc_root: "src/", test_root: "test/") - super(project_root, source_root, inc_root, test_root) - end - end -end - def test_asset_path(asset_file_name) File.join(File.dirname(__FILE__), '..', 'assets', asset_file_name) end @@ -538,60 +524,6 @@ def can_fetch_project_help end end - def can_use_the_module_plugin - @c.with_context do - Dir.chdir @proj_name do - output = `bundle exec ruby -S ceedling module:create[ponies]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Generate Complete/i) - output = `bundle exec ruby -S ceedling test:all` - expect($?.exitstatus).to match(0) - expect(output).to match(/Need to Implement ponies/) - output = `bundle exec ruby -S ceedling module:destroy[ponies]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Destroy Complete/i) - - self.can_use_the_module_plugin_path_extension - self.can_use_the_module_plugin_with_include_path - end - end - end - - def can_use_the_module_plugin_path_extension - @c.with_context do - Dir.chdir @proj_name do - # Module creation - output = `bundle exec ruby -S ceedling module:create[myPonies:ponies]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Generate Complete/i) - expect(File.exist?("myPonies/src/ponies.c")).to eq true - expect(File.exist?("myPonies/src/ponies.h")).to eq true - expect(File.exist?("myPonies/test/test_ponies.c")).to eq true - - # add module path to project file - settings = { :paths => { :test => [ "myPonies/test" ], - :source => [ "myPonies/src" ], - :include => [ "myPonies/src" ] - } - } - add_project_settings("project.yml", settings) - - # See if ceedling finds the test in the subdir - output = `bundle exec ruby -S ceedling test:all` - expect($?.exitstatus).to match(0) - expect(output).to match(/Need to Implement ponies/) - - # Module destruction - output = `bundle exec ruby -S ceedling module:destroy[myPonies:ponies]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Destroy Complete/i) - expect(File.exist?("myPonies/src/ponies.c")).to eq false - expect(File.exist?("myPonies/src/ponies.h")).to eq false - expect(File.exist?("myPonies/test/test_ponies.c")).to eq false - end - end - end - def can_run_single_test_with_full_test_case_name_from_test_file_with_success_cmdline_args_are_enabled @c.with_context do Dir.chdir @proj_name do @@ -739,127 +671,6 @@ def run_all_test_when_test_case_name_is_passed_but_cmdline_args_are_disabled_wit end end - def can_use_the_module_plugin_with_include_path - @c.with_context do - Dir.chdir @proj_name do - # add include path to module generator - mod_gen = Modulegenerator.new(inc_root: "inc/") - settings = { :module_generator => { :project_root => mod_gen.project_root, - :source_root => mod_gen.source_root, - :inc_root => mod_gen.inc_root, - :test_root => mod_gen.test_root - } - } - add_project_settings("project.yml", settings) - - # module creation - output = `bundle exec ruby -S ceedling module:create[myPonies:ponies]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Generate Complete/i) - expect(File.exist?("myPonies/src/ponies.c")).to eq true - expect(File.exist?("myPonies/inc/ponies.h")).to eq true - expect(File.exist?("myPonies/test/test_ponies.c")).to eq true - - # Module destruction - output = `bundle exec ruby -S ceedling module:destroy[myPonies:ponies]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Destroy Complete/i) - expect(File.exist?("myPonies/src/ponies.c")).to eq false - expect(File.exist?("myPonies/inc/ponies.h")).to eq false - expect(File.exist?("myPonies/test/test_ponies.c")).to eq false - end - end - end - - def can_use_the_module_plugin_with_non_default_paths - @c.with_context do - Dir.chdir @proj_name do - # add paths to module generator - mod_gen = Modulegenerator.new(source_root: "foo/", inc_root: "bar/", test_root: "barz/") - settings = { :module_generator => { :project_root => mod_gen.project_root, - :source_root => mod_gen.source_root, - :inc_root => mod_gen.inc_root, - :test_root => mod_gen.test_root - } - } - add_project_settings("project.yml", settings) - - # module creation - output = `bundle exec ruby -S ceedling module:create[ponies]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Generate Complete/i) - expect(File.exist?("foo/ponies.c")).to eq true - expect(File.exist?("bar/ponies.h")).to eq true - expect(File.exist?("barz/test_ponies.c")).to eq true - - # Module destruction - output = `bundle exec ruby -S ceedling module:destroy[ponies]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Destroy Complete/i) - expect(File.exist?("foo/ponies.c")).to eq false - expect(File.exist?("bar/ponies.h")).to eq false - expect(File.exist?("barz/test_ponies.c")).to eq false - end - end - end - - def handles_creating_the_same_module_twice_using_the_module_plugin - @c.with_context do - Dir.chdir @proj_name do - output = `bundle exec ruby -S ceedling module:create[unicorns]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Generate Complete/i) - - output = `bundle exec ruby -S ceedling module:create[unicorns] 2>&1` - expect($?.exitstatus).to match(1) - expect(output).to match(/(?:ERROR: Ceedling Failed)|(?:Ceedling could not complete the build because of errors)/) - end - end - end - - def handles_creating_the_same_module_twice_using_the_module_plugin_extension - @c.with_context do - Dir.chdir @proj_name do - output = `bundle exec ruby -S ceedling module:create[myUnicorn:unicorns]` - expect($?.exitstatus).to match(0) - expect(output).to match(/Generate Complete/i) - - output = `bundle exec ruby -S ceedling module:create[myUnicorn:unicorns] 2>&1` - expect($?.exitstatus).to match(1) - expect(output).to match(/(?:ERROR: Ceedling Failed)|(?:Ceedling could not complete the build because of errors)/) - end - end - end - - def handles_destroying_a_module_that_does_not_exist_using_the_module_plugin - @c.with_context do - Dir.chdir @proj_name do - output = `bundle exec ruby -S ceedling module:destroy[unknown]` - expect($?.exitstatus).to match(0) - - expect(output).to match(/File src\/unknown\.c does not exist so cannot be removed\./) - expect(output).to match(/File src\/unknown\.h does not exist so cannot be removed\./) - expect(output).to match(/File test\/test_unknown\.c does not exist so cannot be removed\./) - expect(output).to match(/Destroy Complete/) - - self.handles_destroying_a_module_that_does_not_exist_using_the_module_plugin_path_extension - end - end - end - - def handles_destroying_a_module_that_does_not_exist_using_the_module_plugin_path_extension - @c.with_context do - Dir.chdir @proj_name do - output = `bundle exec ruby -S ceedling module:destroy[myUnknownModule:unknown]` - expect($?.exitstatus).to match(0) - - expect(output).to match(/File myUnknownModule\/src\/unknown\.c does not exist so cannot be removed\./) - expect(output).to match(/File myUnknownModule\/src\/unknown\.h does not exist so cannot be removed\./) - expect(output).to match(/File myUnknownModule\/test\/test_unknown\.c does not exist so cannot be removed\./) - expect(output).to match(/Destroy Complete/) - end - end - end def test_run_of_projects_fail_because_of_sigsegv_without_report @c.with_context do diff --git a/spec/system/deployment_spec.rb b/spec/system/deployment_spec.rb index a619aced..1bc8ca9f 100644 --- a/spec/system/deployment_spec.rb +++ b/spec/system/deployment_spec.rb @@ -40,14 +40,6 @@ it { can_test_projects_with_both_mock_and_real_header } it { can_test_projects_with_success_when_space_appears_between_hash_and_include } it { uses_raw_output_report_plugin } - it { can_use_the_module_plugin } - it { can_use_the_module_plugin_path_extension } - it { can_use_the_module_plugin_with_include_path } - it { can_use_the_module_plugin_with_non_default_paths } - it { handles_creating_the_same_module_twice_using_the_module_plugin } - it { handles_creating_the_same_module_twice_using_the_module_plugin_extension } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin_path_extension } it { test_run_of_projects_fail_because_of_sigsegv_without_report } it { test_run_of_projects_fail_because_of_sigsegv_with_report } it { execute_all_test_cases_from_crashing_test_runner_and_return_test_report_with_failue_when_cmd_args_set_to_true } @@ -74,7 +66,6 @@ it { contains_a_vendor_directory } it { contains_documentation } it { can_test_projects_with_success } - it { can_use_the_module_plugin } end @@ -101,12 +92,6 @@ it { can_test_projects_with_fail_alias } it { can_test_projects_with_fail_default } it { can_test_projects_with_compile_error } - it { can_use_the_module_plugin } - it { can_use_the_module_plugin_path_extension } - it { can_use_the_module_plugin_with_include_path } - it { handles_creating_the_same_module_twice_using_the_module_plugin } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin_path_extension } end describe "ugrade a project's `vendor` directory" do @@ -130,14 +115,6 @@ it { can_test_projects_with_fail_alias } it { can_test_projects_with_fail_default } it { can_test_projects_with_compile_error } - it { can_use_the_module_plugin } - it { can_use_the_module_plugin_path_extension } - it { can_use_the_module_plugin_with_include_path } - it { can_use_the_module_plugin_with_non_default_paths } - it { handles_creating_the_same_module_twice_using_the_module_plugin } - it { handles_creating_the_same_module_twice_using_the_module_plugin_extension } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin_path_extension } it { can_upgrade_projects } it { can_upgrade_projects_even_if_test_support_folder_does_not_exists } @@ -154,14 +131,6 @@ it { can_test_projects_with_fail_alias } it { can_test_projects_with_fail_default } it { can_test_projects_with_compile_error } - it { can_use_the_module_plugin } - it { can_use_the_module_plugin_path_extension } - it { can_use_the_module_plugin_with_include_path } - it { can_use_the_module_plugin_with_non_default_paths } - it { handles_creating_the_same_module_twice_using_the_module_plugin } - it { handles_creating_the_same_module_twice_using_the_module_plugin_extension } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin_path_extension } end describe "Cannot ugrade a non existing project" do @@ -187,14 +156,6 @@ it { can_test_projects_with_test_and_vendor_defines_with_success } it { can_test_projects_with_fail } it { can_test_projects_with_compile_error } - it { can_use_the_module_plugin } - it { can_use_the_module_plugin_path_extension } - it { can_use_the_module_plugin_with_include_path } - it { can_use_the_module_plugin_with_non_default_paths } - it { handles_creating_the_same_module_twice_using_the_module_plugin } - it { handles_creating_the_same_module_twice_using_the_module_plugin_extension } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin } - it { handles_destroying_a_module_that_does_not_exist_using_the_module_plugin_path_extension } end #TODO: Feature disabled for now.