Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated faces are not connected #124

Open
TheDuckCow opened this issue Sep 18, 2023 · 1 comment
Open

Generated faces are not connected #124

TheDuckCow opened this issue Sep 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@TheDuckCow
Copy link
Owner

TheDuckCow commented Sep 18, 2023

After inspecting a GLTF export of the generated roads, it became very obvious that the generated meshes aren't using shared vertices and aren't being smoothed. In the gltf file, I'm seeing the re-exported cars have connected verts (per the video below), but the road meshes don't

connected.verts.mp4

We will need to update the generator tool to attempt to set connected verts and create smoother shading.

Depending on what is actually happening under the hood, it's very possible that performance is degraded much more than it needs to be due to extra verts (and possibly UV breaks too, since the UV coordinates would also not be shared).

@TheDuckCow TheDuckCow added the bug Something isn't working label Sep 18, 2023
@TheDuckCow TheDuckCow added this to the v1.0.0 | Public launch milestone Sep 18, 2023
@TheDuckCow
Copy link
Owner Author

For what it's worth: when looking at Godot 4, porting the same code as-is, we have something like half of the vertices end up correctly being merged together. Seems to me that the mode for joining verts automatically is too strict or not that reliable, so either way we'd need a more deterministic way to ensure verts get reused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant