Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes made for button #125

Closed
wants to merge 3 commits into from
Closed

Changes made for button #125

wants to merge 3 commits into from

Conversation

kisharnath
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Jan 8, 2024 •
edited
Loading

👷 Deploy request for lichterio pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d497342

TheAlexLichter
TheAlexLichter requested changes Jan 8, 2024
View reviewed changes
Copy link
Owner

@TheAlexLichter TheAlexLichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initial changes! Could we:

  1. Stick to TailwindCSS?
  2. Still use the AppButton for the buttons? 🤔

@kisharnath
Copy link
Contributor Author

I am unable to find the right class for this ,Should I make custom class in tailwind?
And (Still use the AppButton for the buttons? ) This means can AppButton be used as button am I right?

@TheAlexLichter
Copy link
Owner

@kisharnath The idea that this button should work with less elements. If tailwind doesn't have the utilities for it, you can use it's arbitrary syntax.
Default: image
On Hover:
image

@kisharnath
Copy link
Contributor Author

Can you check now?

TheAlexLichter
TheAlexLichter requested changes Jan 9, 2024
View reviewed changes
assets/css/tailwind.css Outdated
@import 'tailwindcss/components';
@import 'tailwindcss/utilities';

.newButton{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, please use Tailwinds Arbitrary syntax ☺️
If that is not possible at all, Vue's scoped styles are also fine, but then use @apply where possible

@kisharnath
Copy link
Contributor Author

Can you check out now ?

@TheAlexLichter TheAlexLichter self-requested a review January 18, 2024 07:20
@TheAlexLichter TheAlexLichter linked an issue Feb 11, 2024 that may be closed by this pull request
Improve button gradient borders #114
Open
@TheAlexLichter
Copy link
Owner

Hey @kisharnath! Thanks for your work so far. Unfortunately, the styles don't match the original. The border on the side is thinner than on the top and bottom. Also, when hovering there is no gradient anymore.
image

@kisharnath
Copy link
Contributor Author

Please check now

@TheAlexLichter
Copy link
Owner

@kisharnath can you check my comments @ https://youtu.be/K-2r2rXHEdo?t=6528? ☺️

@kisharnath kisharnath closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAlexLichter TheAlexLichter Awaiting requested review from TheAlexLichter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve button gradient borders
2 participants
@kisharnath @TheAlexLichter