Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlines are not smooth #526

Open
5 tasks done
pstowasser01 opened this issue Nov 11, 2024 · 1 comment
Open
5 tasks done

Outlines are not smooth #526

pstowasser01 opened this issue Nov 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pstowasser01
Copy link
Contributor

Describe the bug 📝

When using the postproduction.customEffects I want to add an outline to my fragments as without it looks blank and feels somewhat difficult to identify where specific elements end or begin.

To add this I am enabling postproduction, set the customEffects.linecolor and exclude my grid mesh from this customEffect.
I also create my renderer with the WebGLRenderParameter "antialias: true" from which I hoped to smooth the edges my elements...

The elements on their own DO have a smooth edge but the outlines are still pixilated like shown in the following screenshots:

*postproduction.enabled = false (to stop drawing outlines)
image

*enabled postproduction and everything I was talking above:
image

Reproduction ▶️

No response

Steps to reproduce 🔢

  • Use a OBCF.PostproductionRenderer with the parameter "antialias: true"
  • Enable postproduction and set the lineColor (optional: exclude grid-mesh from customEffects)
  • Load a model

System Info 💻

Using following dependencies:
 "@thatopen/components": "^2.3.18",
 "@thatopen/components-front": "^2.3.13",
 "@thatopen/fragments": "^2.3.0",
 "@thatopen/ui": "^2.3.1",
 "@thatopen/ui-obc": "^2.3.4",

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.
@pstowasser01 pstowasser01 added the bug Something isn't working label Nov 11, 2024
@agviegas
Copy link
Contributor

Hello @pstowasser01 we are aware of this issue and we are working on a better postproduction renderer that solves this problem. We will keep you updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants