Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to remove entities (for instance ifcDocumentReference and the related association) #502

Open
4 of 5 tasks
TristanLecallierABIME opened this issue Sep 25, 2024 · 1 comment
Assignees
Labels
feature Something new that we could do

Comments

@TristanLecallierABIME
Copy link

TristanLecallierABIME commented Sep 25, 2024

Describe the bug 📝

The situation : I have an ifc with inside an ifcDocumentReference entity and some ifcElements related to it with an ifcRelAssociatesDocument association.
I want to delete the ifcDocumentReference and also the relationship, and then save to ifc.

The issues :

  • for deleting the entity I use : await model.setProperties(documentReferenceExpressId, {});
    But this does not delete the entity when I save to ifc (with await propertiesManager.saveToIfc(model, new Uint8Array(originalBuffer));, because setProperties doesn't impact the ifcPropertiesManager.changeMap which is used to edit the ifc inside saveToIfc function.

  • for deleting association, there is no function like indexer.removeEntitiesRelation

Reproduction ▶️

No response

Steps to reproduce 🔢

No response

System Info 💻

"@thatopen/components": "^2.2.10",
"@thatopen/components-front": "^2.2.2",
"@thatopen/fragments": "^2.2.0",
"web-ifc": "0.0.57",

Used Package Manager 📦

pnpm

Error Trace/Logs 📃

No response

Validations ✅

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.
@TristanLecallierABIME TristanLecallierABIME added the bug Something isn't working label Sep 25, 2024
@agviegas agviegas changed the title Issue removing an entity (for instance ifcDocumentReference and the related association) Allow to remove entities (for instance ifcDocumentReference and the related association) Oct 13, 2024
@agviegas agviegas added feature Something new that we could do and removed bug Something isn't working labels Oct 13, 2024
@HoyosJuan
Copy link
Member

HoyosJuan commented Nov 5, 2024

Hey @TristanLecallierABIME!

I was taking a look at this the other day, and defined the best way to do it will require a breaking change in the indexation structure (meaning old-processed indexations won't be compatible with the new one). We avoid making breaking changes in minor versions, but for one single feature it doesn't make sense to create a new major version.

In case we don't find another way that integrates with the existing indexation structure (that is also efficient), we will wait until some other breaking changes to occur to group them all in one single major release 🙂

Will keep this updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something new that we could do
Projects
None yet
Development

No branches or pull requests

3 participants