From 7a26fa2993f90484df6a981c4611bb4baa959042 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Antonio=20Gonz=C3=A1lez=20Viegas?=
 <antoniogviegas@hotmail.com>
Date: Tue, 1 Oct 2024 11:34:58 +0200
Subject: [PATCH] feat: add offset to walls

---
 .../clay/src/elements/Walls/SimpleWall/example.ts  | 10 ++++++++++
 .../SimpleWall/src/simple-wall-clipping-planes.ts  | 14 ++++++++------
 .../elements/Walls/SimpleWall/src/simple-wall.ts   | 14 +++++++++++++-
 3 files changed, 31 insertions(+), 7 deletions(-)

diff --git a/packages/clay/src/elements/Walls/SimpleWall/example.ts b/packages/clay/src/elements/Walls/SimpleWall/example.ts
index be6586d..aecc822 100644
--- a/packages/clay/src/elements/Walls/SimpleWall/example.ts
+++ b/packages/clay/src/elements/Walls/SimpleWall/example.ts
@@ -148,6 +148,16 @@ const panel = BUI.Component.create<BUI.PanelSection>(() => {
         simpleWallType.updateCorners();
       }}"></bim-number-input>
       
+      <bim-number-input slider step="0.01" label="Offset" value="${wall1.offset}" @change="${(
+        event: any,
+      ) => {
+        wall1.offset = event.target.value;
+        wall1.update(true);
+        wall2.offset = event.target.value;
+        wall2.update(true);
+        simpleWallType.updateCorners();
+      }}"></bim-number-input>
+      
       <bim-number-input slider step="0.05" label="Thickness" value="${simpleWallType.width}" @change="${(
         event: any,
       ) => {
diff --git a/packages/clay/src/elements/Walls/SimpleWall/src/simple-wall-clipping-planes.ts b/packages/clay/src/elements/Walls/SimpleWall/src/simple-wall-clipping-planes.ts
index b9af7b5..ad6625a 100644
--- a/packages/clay/src/elements/Walls/SimpleWall/src/simple-wall-clipping-planes.ts
+++ b/packages/clay/src/elements/Walls/SimpleWall/src/simple-wall-clipping-planes.ts
@@ -55,22 +55,24 @@ export class SimpleWallClippingPlanes {
   }
 
   update() {
-    const offset = this._wall.type.width / 2;
+    const width = this._wall.type.width / 2;
 
     const temp = new THREE.Object3D();
 
     const downDirection = this._wall.normal;
     const upDirection = downDirection.clone().multiplyScalar(-1);
 
-    const downOffset = downDirection.clone().multiplyScalar(offset);
-    const downPoint = this._wall.startPoint3D.add(downOffset);
+    const offsetOffset = upDirection.clone().multiplyScalar(this._wall.offset);
 
-    const upOffset = upDirection.clone().multiplyScalar(offset);
-    const upPoint = this._wall.startPoint3D.add(upOffset);
+    const downOffset = downDirection.clone().multiplyScalar(width);
+    const downPoint = this._wall.startPoint3D.add(downOffset).add(offsetOffset);
+
+    const upOffset = upDirection.clone().multiplyScalar(width);
+    const upPoint = this._wall.startPoint3D.add(upOffset).add(offsetOffset);
 
     const { downDown, upDown, downUp, upUp } = this.list;
 
-    temp.position.copy(this._wall.startPoint3D);
+    temp.position.copy(this._wall.startPoint3D.add(offsetOffset));
     temp.lookAt(downPoint);
 
     downDown.position.copy(downPoint);
diff --git a/packages/clay/src/elements/Walls/SimpleWall/src/simple-wall.ts b/packages/clay/src/elements/Walls/SimpleWall/src/simple-wall.ts
index 6496364..c21f5fb 100644
--- a/packages/clay/src/elements/Walls/SimpleWall/src/simple-wall.ts
+++ b/packages/clay/src/elements/Walls/SimpleWall/src/simple-wall.ts
@@ -29,6 +29,8 @@ export class SimpleWall extends ClayElement {
 
   endPoint = new THREE.Vector2(1, 0);
 
+  offset = 0;
+
   planes: SimpleWallClippingPlanes;
 
   private _nester = new SimpleWallNester(this);
@@ -108,6 +110,7 @@ export class SimpleWall extends ClayElement {
     const profile = this.body.profile;
     profile.dimension.x = this.length;
     profile.dimension.y = this.type.width;
+    profile.position.y = this.offset;
     profile.update();
 
     this.body.depth = this.height;
@@ -149,6 +152,8 @@ export class SimpleWall extends ClayElement {
   }
 
   getPlane(type: WallPlaneType = "center") {
+    const normal = this.normal;
+
     const p1 = this.startPoint3D;
     const p2 = this.endPoint3D;
     const p3 = p1.clone();
@@ -159,8 +164,15 @@ export class SimpleWall extends ClayElement {
       return null;
     }
 
+    const offsetCorrection = normal.clone();
+    offsetCorrection.multiplyScalar(-this.offset);
+
+    p1.add(offsetCorrection);
+    p2.add(offsetCorrection);
+    p3.add(offsetCorrection);
+
     if (type !== "center") {
-      const offset = this.normal;
+      const offset = normal.clone();
       const factor = type === "exterior" ? 1 : -1;
       const offsetAmount = (this.type.width / 2) * factor;
       offset.multiplyScalar(offsetAmount);