-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No preview for a link in Skype #107
Comments
Weird, one would expect that to be done purely by the client-side receiver ( Guess that means the sending client is now expected to include some extra markup on links? What does a link in the raw message look like when sent from the new Skype for Web? |
I mean the actual message content, not Skype for Web's rendering of it. Send a message from new Skype for Web, receive it in SkPy, and check |
Here is a msg content of several msgs:
You've written that class should be If Cyrillic is bothering you, I could make a post in English :) |
No obvious additional markup then. 😐 If you try sending a message from SkPy and from new Skype for Web, there may be some clues if you compare the For SkPy, you need to retrieve the message from the server rather than looking at the one you just sent. Easiest way is to send the same link via SkPy and S4W, then retrieve both using
|
Interesting that links that sent from old S4W have no preview in a new one. The content text of
|
I'm not sure what that blob is, where did you get it? I just tried sending from old and new S4Ws, the payload as seen from old S4W (and therefore from SkPy) appears to be the same: >>> pprint.pprint(sk.chats['8:fred.2'].getMsgs()[0].raw)
{'clientmessageid': '1551607385077',
'composetime': '2019-03-03T10:05:21.259Z',
'content': '<a href="https://medium.com/s/story/why-i-stopped-arguing-politics-on-social-media-f695344d3e3">'
'https://medium.com/s/story/why-i-stopped-arguing-politics-on-social-media-f695344d3e3</a>',
'conversationLink': 'https://ch1-client-s.gateway.messenger.live.com/v1/users/ME/conversations/8:fred.2',
'conversationid': '8:fred.2',
'from': 'https://ch1-client-s.gateway.messenger.live.com/v1/users/ME/contacts/8:fred.2',
'id': '1551607521743',
'messagetype': 'RichText',
'originalarrivaltime': '2019-03-03T10:05:21.259Z',
'type': 'Message',
'version': '1551607521743'} Given the sending model is completely different in new S4W (sent via an open websocket in a different format), I'm not sure if this is actually fixable using the old endpoint. The fact that links sent from old S4W don't expand either at least confirms it's not a library issue, but one with the API we're using. |
How big this task is? Maybe I could implement it |
See notes in #105. |
No preview for a link in Skype. When I sent a similar link through the Skype app there is a preview, but not with skpy.
I've found that I can fetch link manually by call
getUrlMeta
but I have no idea where to past that response.UPD:
Preview does work with old version of Skype for Web, but not in new one and other versions.
Account type
Live account
Steps to reproduce
Result or traceback
Just regular text without link preview.
The text was updated successfully, but these errors were encountered: