Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hover/pressed tokens #1979

Merged
merged 1 commit into from
Dec 10, 2024
Merged

update hover/pressed tokens #1979

merged 1 commit into from
Dec 10, 2024

Conversation

andredelramo-hm
Copy link
Collaborator

Update the tokens backgroundContainerHover to 0.05 and backgroundContainerPressed to 0.08. Additionally, the Blau token will use blauBlueSecondary from its palette, and Telefonia will use telefonicaBlue70.

Copy link
Collaborator

@aweell aweell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with backgroundContainerBrandHover and backgroundContainerBrandPressed in the brands that have also the values of 0.03 and 0.05 in dark? wouldn't be weird to have different values

Screenshot 2024-11-28 at 20 21 34

@aweell
Copy link
Collaborator

aweell commented Nov 28, 2024

@andredelramo-hm
Copy link
Collaborator Author

@aweell I understand your point, but I'm not sure if it should be considered another issue. I would need to see where tokens are being used and understand why there are differences between dark and light modes.

https://www.figma.com/design/nBIZk0SZEeL9g6f5KnJwNF/Test-hover-and-pressed-tokens?node-id=0-1&t=D99wxkE7dSM5vCX1-1

@aweell
Copy link
Collaborator

aweell commented Dec 10, 2024

@aweell I understand your point, but I'm not sure if it should be considered another issue. I would need to see where tokens are being used and understand why there are differences between dark and light modes.

https://www.figma.com/design/nBIZk0SZEeL9g6f5KnJwNF/Test-hover-and-pressed-tokens?node-id=0-1&t=D99wxkE7dSM5vCX1-1

https://www.figma.com/design/vCUyyZapiXKAe6TFJmvQyw?node-id=2071-1948#1033275331

These tokens where meant to be used for overlays that are on top of containers with brand colors (for example a poster or display data inverse card) since the amount of black needed to show a change over brand vs over white is not the same.

For the sake of consistency i would use these tokens in the Action/navigation + active variant as suggested. In that case at least we would need to change those to the same values the "non brand" tokens now will have in dark.

@aweell aweell added this pull request to the merge queue Dec 10, 2024
Merged via the queue into production with commit 77e11f2 Dec 10, 2024
9 checks passed
@aweell aweell deleted the aramo-tokens-hover-pressed branch December 10, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants