Add backgroundContainerError and textError tokens #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceballost
requested changes
Apr 16, 2024
|
Please, change the PR name to something more specific. Like "Add backgroundContainerError and textError tokens" |
paulasuarezb
changed the title
aweell
reviewed
Apr 16, 2024
added textErrorInverse token and changed backgroundContainerError palette same as errorLow
aweell
requested changes
Apr 16, 2024
textErrorInverse in dark should be = textError in all brands
yceballost
requested changes
Apr 16, 2024
|
You can check the effect of your changes here: https://mistica-design.vercel.app/tokens-map?branch=%231708-Rowlist-danger&skin=movistar&tokenType=color&activeColor=undefined |
|
I think I got it now 😅 that url was really helpful |
yceballost
approved these changes
Apr 17, 2024
aweell
requested changes
Apr 17, 2024
changed O2-new text-Error and vivo-new textErrorInverse
Co-authored-by: Alex Bueno <[email protected]>
aweell
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1708 Rowlist danger