Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mediaSmall radii token #1562

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Add mediaSmall radii token #1562

merged 2 commits into from
Nov 17, 2023

Conversation

aweell
Copy link
Collaborator

@aweell aweell commented Nov 15, 2023

No description provided.

@aweell aweell requested a review from yceballost November 15, 2023 08:21
Copy link
Collaborator

@yceballost yceballost Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tendría sentido tener tb un token para images/video default?

  • media
  • mediaSmall

entiendo que esto tb aplicaría a un video pequeño?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiene todo el sentido utilizar media si, el default es equivalente a container, no se si queremos aquí desvincular esos dos aun teniendo el mismo valor.

Me lo plantee al iniciar la tarea y me parecía más adecuado que fuesen de la mano ya que asumía que cuando cambiemos container vamos a cambiar media (default) también

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm sep, de momento podemos mantenerlo en container. Si más adelante necesitamos desvincularlo ya tenemos el way to go

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm sep, de momento podemos mantenerlo en container. Si más adelante necesitamos desvincularlo ya tenemos el way to go

@yceballost yceballost changed the title Add imageSmall radii token Add mediaSmall radii token Nov 17, 2023
@yceballost yceballost merged commit 5542488 into production Nov 17, 2023
8 checks passed
@yceballost yceballost deleted the aweell-imageSmall-token branch November 17, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants