Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brandLoadingScreen themeVariant token #1807

Closed
1 of 8 tasks
aweell opened this issue Jun 20, 2024 · 0 comments · Fixed by #1822
Closed
1 of 8 tasks

Add brandLoadingScreen themeVariant token #1807

aweell opened this issue Jun 20, 2024 · 0 comments · Fixed by #1822
Assignees
@aweell
Labels
changelog: added component: loading screen fundamentals: tokens
Milestone
14.1.0

Comments

@aweell
Copy link
Collaborator

aweell commented Jun 20, 2024 •
edited
Loading

Description

In order to provide an accessible color combination for all brands we found necessary to determine via skin when the brandLoadingScreen is inverse or not. This will be defined in each brand skin under a new category "themeVariant":

"themeVariant" : {
     "brandLoadingScreen" : {
              "value" : "default" | "inverse" | "alternative" 
}

Tasks

  • Update specs
  • Design documentation
  • Add to mobile library
  • Add to desktop library
  • Add to UI Kit
  • Android ticket
  • iOS ticket
  • Web ticket
@aweell aweell added this to the 14.1.0 milestone Jul 1, 2024
@aweell aweell self-assigned this Jul 5, 2024
@aweell aweell moved this from Backlog to In progress (specs) in Mística Design System Jul 5, 2024
@aweell aweell linked a pull request Jul 8, 2024 that will close this issue
Add themeVariant token for brandLoadingScreen #1822
Merged
@aweell aweell moved this from In progress (specs) to In review (specs) in Mística Design System Jul 8, 2024
@yceballost yceballost mentioned this issue Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aweell aweell

Labels
changelog: added component: loading screen fundamentals: tokens
Projects
Mística Design System
Status: In review (specs)
Milestone
14.1.0
Development

Successfully merging a pull request may close this issue.

Add themeVariant token for brandLoadingScreen Telefonica/mistica-design
1 participant
@aweell