GVS broken with WoW 8.0

[Kyphala]

Will there be an update to WoW 8.0 BoA or do we need to look for an alternative ?

Currently the Item description stay empty. You just see the Icon and price. Need to look to tool type for every entry to find out what you are buying

Did not happen for every Entry and sometimes it looks OK first but the Names vanish the time you scroll down.

[Talyrius]

Look at the pull requests to see the necessary code changes.

[Ookami313]

I applied the fixes listed in the pull requests, but as soon as I log in i'm getting the following error. Did I swap code incorrectly, or is it something else causing the issue? Thanks.

Date: 2018-08-01 23:03:25
ID: 5
Error occured in: Global
Count: 1
Message: ...dOns\GnomishVendorShrinker\externals\size_to_fit.lua line 32:
Usage: :SetSize(width, height)
Debug:
(tail call): ?
[C]: ?
[C]: SetSize()
...dOns\GnomishVendorShrinker\externals\size_to_fit.lua:32: SizeToFit()
...dOns\GnomishVendorShrinker\externals\size_to_fit.lua:16:
...dOns\GnomishVendorShrinker\externals\size_to_fit.lua:13
...dOns\GnomishVendorShrinker\externals\size_to_fit.lua:28: SizeToFit()
...\AddOns\GnomishVendorShrinker\frames\AltCurrency.lua:29: SetValue()
...AddOns\GnomishVendorShrinker\frames\MerchantItem.lua:138: SetValue()
...ce\AddOns\GnomishVendorShrinker\frames\MainFrame.lua:42:
...ce\AddOns\GnomishVendorShrinker\frames\MainFrame.lua:33
[C]: SetValue()
...ce\AddOns\GnomishVendorShrinker\frames\MainFrame.lua:69:
...ce\AddOns\GnomishVendorShrinker\frames\MainFrame.lua:65
GnomishVendorShrinker\Init.lua:31:
GnomishVendorShrinker\Init.lua:29
[C]: SetMerchantFilter()
+Wowhead_Looter\Wowhead_Looter.lua:1179: wlEvent_MERCHANT_UPDATE()
+Wowhead_Looter\Wowhead_Looter.lua:1159: ?()
+Wowhead_Looter\Wowhead_Looter.lua:4362:
+Wowhead_Looter\Wowhead_Looter.lua:4360
Locals:
(*temporary) = defined =[C]:-1

AddOns:

[Kyphala]

Code change doesn't work for me...... same problem.....

[exochron]

simple solution: in frames/MerchantItem.lua:203
just remove or comment out
ItemName:SetPoint("RIGHT", AltCurrency, "LEFT", -GAP, 0)

[Kyphala]

if it is "so easy" why isnt that change moved into the programm ?
Why must everypne make this change by himself ?

[Gnarfoz]

Because the author has other things to do, apparently, as is his prerogative. ;-)
And barring an explicit licence that allows someone else to, they are the only one privileged to officially maintain and release this addon.
You could look at https://github.com/Vladinator89/wow-addon-compactvendor (also available on Curse & WoWInterface), which is actively maintained and does something basically the same thing.