Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 8.0 #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update to 8.0 #55

wants to merge 2 commits into from

Conversation

Shauren
Copy link

@Shauren Shauren commented Jul 20, 2018

Also fixed that old annoyance with resetting scroll after buying items

Closes #51
Closes #54

@bradxeno
Copy link

Testing both fixes, zero issues so far.

@DarkVirtue
Copy link

The fixes are working well for me, too.

@ckaotik
Copy link

ckaotik commented Jul 26, 2018

Ah, so that's why the texts sometimes go missing. Thanks for figuring that out!

@Myrroddin
Copy link

Myrroddin commented Jul 27, 2018

Line 35 of ui-scrollbar.lua in the externals folder must be changed to the following. Er, this is before any other applied fixes.
PlaySoundKit(SOUNDKIT.UChatScrollButton)

@spiralofhope
Copy link

spiralofhope commented Jul 16, 2019

Could you please also check out these commits:

  1. e62f58f

  2. f48fc9c

  3. fbdf467

  4. frames\QtyPopout.lua from:

OpenStackSplitFrame(250, self, "LEFT", "RIGHT")

to:

StackSplitFrame:OpenStackSplitFrame(250, self, "LEFT", "RIGHT")
  1. Mmkbfa #56 (comment)

Line 35 of ui-scrollbar.lua in the externals folder must be changed to
PlaySoundKit(SOUNDKIT.UChatScrollButton)

I have made all of your changes, and also these five more, and they all seem to work.

@spiralofhope spiralofhope mentioned this pull request Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vendor page popping up to the top after each buy. (8.0.1) Item text blank at vendors
6 participants