Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate version bump PRs in this repo #1575

Open
alodahl opened this issue Jun 24, 2021 · 2 comments
Open

validate version bump PRs in this repo #1575

alodahl opened this issue Jun 24, 2021 · 2 comments
Labels
EASY Quick or simple task good-first-issue Simple issue for those new to the repo or open-source in general

Comments

@alodahl
Copy link
Collaborator

alodahl commented Jun 24, 2021

Please test these version bump PRs locally to ensure that our package.json commands run without any new warnings or errors. Please let us know if we're clear to merge, or if there are issues. Gracias!

#1568
#1567
@alodahl alodahl added good-first-issue Simple issue for those new to the repo or open-source in general EASY Quick or simple task labels Jun 24, 2021
@alodahl alodahl changed the title validate version bump PRs validate version bump PRs in this repo Jun 24, 2021
@parbindersingh
Copy link

Hi @alodahl, It is fine to bump both dependencies. Although to be clear, the changes will drop the support of Node versions < 10.
Since, node is now at its 16th version, updating these should not cause any problem.

@chrisjaure
Copy link
Contributor

Looks like this ticket can be closed because both of the referenced PRs have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
EASY Quick or simple task good-first-issue Simple issue for those new to the repo or open-source in general
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chrisjaure @gabymoreno9 @alodahl @daaimah123 @parbindersingh