Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojang version.json files never get re-validated #144

Open
Pyker opened this issue Jul 1, 2020 · 0 comments
Open

Mojang version.json files never get re-validated #144

Pyker opened this issue Jul 1, 2020 · 0 comments

Comments

@Pyker
Copy link
Member

Pyker commented Jul 1, 2020

Like the title says, Mojang version.json files never get re-validated. By "Mojang version.json files" I mean the Minecraft version info files, like this one: https://launchermeta.mojang.com/v1/packages/3268559d83cffc8687ed3e282c1edb0d72ed6e75/1.16.json

When a modpack is installed/reinstalled (or updated, which triggers a reinstall), the file matching the modpack's MC version is downloaded from our mirror, but that file never actually gets revalidated. There's no hash checking (there isn't a hash to begin with), no ETag checking, no "If-Modified-Since" checking. But there needs to be. Sometimes updates are pushed out by Mojang to already-released versions (usually to update the asset index).

@Pyker Pyker added the Priority: High High priority label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant