Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating generateImage() #24

Open
HassanDev13 opened this issue Jan 17, 2024 · 3 comments
Open

Repeating generateImage() #24

HassanDev13 opened this issue Jan 17, 2024 · 3 comments

Comments

@HassanDev13
Copy link

I see the hack and my curiosity was piqued XD

the message say "This is a hack to ensure that image generated is as expected. Without repeating generateImage(), at times, the image wont be generated correctly"

when i try this ( by removing repetition ) :

const handleDownload = async () => { // TODO: Fix if possible. This is a hack to ensure that image generated is as expected. Without repeating generateImage(), at times, the image wont be generated correctly. const generatedImageUrl = await generateImage() if (generatedImageUrl) { download(generatedImageUrl, "profile-pic.png") } };

the output work as expected, where is the problem ?

thank you for you good work

@UmairJibran
Copy link
Contributor

Did you try it on mobile devices too? I think the issue is with mobile devices

I rmmbr I see the issue when on mobile device - not sure if it's an iOS issue or Android issue. i.e. happens on mobile device iirc.

@kohrVid
Copy link
Contributor

kohrVid commented Jan 21, 2024

I've noticed that the startOver() function doesn't work as expected on desktop so if I generate a profile image from my GitHub display picture, it isn't possible to try again with my Twitter profile (it somehow always generates the same image as before). Was the hack an attempt to fix that problem?

If so, I wonder if the startOver() could just be re-written like this as a work-around:

const startOver = () => {
  window.location.reload();
};

@UmairJibran
Copy link
Contributor

UmairJibran commented Jan 21, 2024

That's a clever work-around.

Can you fix this in #22? I'll tag you there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants