Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Release as a framework #105

Open
ethanresnick opened this issue May 6, 2015 · 8 comments
Open

Release as a framework #105

ethanresnick opened this issue May 6, 2015 · 8 comments

Comments

@ethanresnick
Copy link
Member

Just a v0 w/ no compatibility promises

@maxdumas
Copy link
Member

maxdumas commented Jun 3, 2015

sure np bro

@freialobo
Copy link
Member

^thats so cute

@ethanresnick
Copy link
Member Author

@maxdumas sarcasm?

@maxdumas
Copy link
Member

maxdumas commented Jun 3, 2015

@ethanresnick Yeah haha, as is the small tag. I realized we didn't talk about this at all at the meeting, although this is a pretty serious consideration that pretty much everything I do in the intranet going forward should be mindful of. I'm still not totally sure how to approach this; I'm not sure about the specifics of library design on top of Angular. That said I am going to put a heavy emphasis going forward on all specific values being provided via configuration or data.

@ethanresnick
Copy link
Member Author

Using more configuration options sounds like a good start. And, yeah, the small tag should've been a tipoff. That said, are we really that far from being able to release this? I mean, most of the code is already generic/decoupled from any tech@nyu-specific purpose, right? (Except for the logic stuff.)

@maxdumas
Copy link
Member

maxdumas commented Jun 3, 2015

Right. It's more of an issue of what to decouple, and how it should be decoupled. A lot of our logic is in the controllers right now which don't really make sense to put into some framework/library; as far as I understand pretty much anything that would go into an Angular framework should be a service. To prepare for that I've started moving some of our stuff to services.

@AbhiAgarwal
Copy link
Member

Also! more comments + documentation

@ethanresnick
Copy link
Member Author

Right. It's more of an issue of what to decouple, and how it should be decoupled.

Totally fair. I was trying to address this originally by just saying "let's release it as a v0", which, under semver, means we can break whatever we want and no one can complain. So we could refactor as we go. But the impetus for that was primarily to launch simultaneously with JSON API. Now, since we've already missed that deadline, we can spend probably spend a little more time getting the architecture right before we put out anything meant for public use. That'll save us time on docs etc in the long run, which, as Abhi points out, would be another to do.

@maxdumas maxdumas added huge and removed small labels Jun 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants