-
Notifications
You must be signed in to change notification settings - Fork 3
Release as a framework #105
Comments
sure np bro |
^thats so cute |
@maxdumas sarcasm? |
@ethanresnick Yeah haha, as is the small tag. I realized we didn't talk about this at all at the meeting, although this is a pretty serious consideration that pretty much everything I do in the intranet going forward should be mindful of. I'm still not totally sure how to approach this; I'm not sure about the specifics of library design on top of Angular. That said I am going to put a heavy emphasis going forward on all specific values being provided via configuration or data. |
Using more configuration options sounds like a good start. And, yeah, the small tag should've been a tipoff. That said, are we really that far from being able to release this? I mean, most of the code is already generic/decoupled from any tech@nyu-specific purpose, right? (Except for the logic stuff.) |
Right. It's more of an issue of what to decouple, and how it should be decoupled. A lot of our logic is in the controllers right now which don't really make sense to put into some framework/library; as far as I understand pretty much anything that would go into an Angular framework should be a service. To prepare for that I've started moving some of our stuff to services. |
Also! more comments + documentation |
Totally fair. I was trying to address this originally by just saying "let's release it as a v0", which, under semver, means we can break whatever we want and no one can complain. So we could refactor as we go. But the impetus for that was primarily to launch simultaneously with JSON API. Now, since we've already missed that deadline, we can spend probably spend a little more time getting the architecture right before we put out anything meant for public use. That'll save us time on docs etc in the long run, which, as Abhi points out, would be another to do. |
Just a v0 w/ no compatibility promises
The text was updated successfully, but these errors were encountered: