Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soundcloud comments extraction fails for some videos (“Page doesn't contain an URL”) #1243

Open
6 tasks done
Profpatsch opened this issue Nov 21, 2024 · 1 comment
Open
6 tasks done
Labels
bug Issue is related to a bug soundcloud service, https://soundcloud.com/

Comments

@Profpatsch
Copy link
Contributor

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I am aware that this issue is being opened for the NewPipe Extractor, NOT the app, and my bug report will be dismissed otherwise.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

9fb03f6

Steps to reproduce the bug

Try to load the comments for e.g. https://soundcloud.com/user-722618400/a-real-playa

Expected behavior

Comments should be returned

Actual behavior

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: GB
  • Content Language: en-GB
  • App Language: en_GB
  • Service: none
  • Version: 0.27.2
  • OS: Linux Android 13 - 33
Crash log

java.lang.IllegalArgumentException: Page doesn't contain an URL
	at org.schabi.newpipe.extractor.services.soundcloud.extractors.SoundcloudCommentsExtractor.getPage(SoundcloudCommentsExtractor.java:44)
	at org.schabi.newpipe.extractor.comments.CommentsInfo.getMoreItems(CommentsInfo.java:79)
	at org.schabi.newpipe.paging.CommentsSource$load$info$1.invokeSuspend(CommentsSource.kt:23)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:113)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:589)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:823)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:720)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:707)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [LazyStandaloneCoroutine{Cancelling}@16d25a5, Dispatchers.Main.immediate]


Originally posted by @Stypox in TeamNewPipe/NewPipe#11060 (comment)

Screenshots/Screen recordings

No response

Logs

No response

Additional information

See TeamNewPipe/NewPipe#11728

@Profpatsch Profpatsch added the bug Issue is related to a bug label Nov 21, 2024
@Profpatsch
Copy link
Contributor Author

From a very short debugging session, it looks like multiple pages of comments are loaded, and at one point the Page object contains a null URL (probably when there’s no more comments to load).

@opusforlife2 opusforlife2 added the soundcloud service, https://soundcloud.com/ label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug soundcloud service, https://soundcloud.com/
Projects
None yet
Development

No branches or pull requests

2 participants