Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name SeleniumDriver is confusing #7

Open
v-mwalk opened this issue Jan 9, 2020 · 0 comments
Open

Name SeleniumDriver is confusing #7

v-mwalk opened this issue Jan 9, 2020 · 0 comments

Comments

@v-mwalk
Copy link
Member

v-mwalk commented Jan 9, 2020

Discussion with a colleague confirmed using the name SeleniumDriver for the root class is confusing. With method names that are the same as Selenium (such as FindElement) but with different functionality there is much confusion.

To resolve this, I propose renaming SeleniumDriver to Controlium (open to suggestions!) and perhaps the renaming of methods that clash with Selenium - IE. FindElement->ElementFind etc. Note that the old names would still be persisted to ensure backwards compatibility but marked as depreciated.

In addition, HTML blocks - which is what Controlium is based around - should be referred to as Components; which is what there are referred to as in the dev world. This would mean - for example - ControlBase (the base abstract class all components inherit from) would be named simply Component.

This would mean a major rework, and an update to the Java version as well. However, the conversation with the colleague was really just a confirmation. He put is very eloquently, asking what Controlium brought that Selenium didn't already , and the prime reason was the naming confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant