-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce overdraw on About activity #3109
Comments
i would like to contribute! what i need to do now? |
Sure!
As said in the comment, the purpose of this issue is essentially to reduce overdraw on |
@ArunPrasanth-V seems like you can decide this - can you work on both under this, provided this is a |
since it is my first contribution. i need to move all the nested layout to a constraintLayout. |
@ArunPrasanth-V Hi! Thanks for showing interest. I think docs would be a good place to started with ConstraintLayout. Also, feel free to join our telegram group if you've any queries :) |
@VishnuSanal i'm having doubt As you said moving all the nested layouts such as Relative layout. whether i need to replace all the RelativeLayout to ConstraintLayout in the code. |
@ArunPrasanth-V Nope, I felt like everything can be done with a single ConstraintLayout as the root. If we replace every RelativeLayout with ConstraintLayout, we aren't reducing any overdraw. |
@VishnuSanal I need to change root layout (LinearLayout) to ConstraintLayout right! in the given code
if i'm worng correct me! |
Need not replace the root
Yes, you'd need to replace every |
@ArunPrasanth-V Any updates here? |
@VishnuSanal I have changed LinearLayout to ConstraintLayout. Have a look at it! |
@VishnuSanal I couldn't figure out where the view was overdrawn. |
@ArunPrasanth-V I'll review your PR & give you my suggestions there, in a while. :) |
Okay, as pointed out early, changes on #3109 does not reduce any overdraw. The intention of this issue was to necessarily remove the nested layouts and replace them with a Please refer to the tageed comment from this thread for reference. :)
|
@ArunPrasanth-V Are you still working on this? |
Hi @VishnuSanal , I am new to open source contribution, But i know development. |
Is it still open to work? Can i contribute to it? |
Overdraw issue has been fixed in activity_about.xml. Should i open pull request now? |
activity_about.xml
currently usesLinearLayout
s, nestedRelativeLayout
s etc. I think we can reduce overdraws by using aConstraintLayout
. Moving "Translators" and "Contributors" toRecyclerView
s would be helpful too.The text was updated successfully, but these errors were encountered: