Skip to content

lets see if node 18 works #10

lets see if node 18 works

lets see if node 18 works #10

GitHub Actions / Ubuntu succeeded Nov 5, 2024 in 0s

Ubuntu

12 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 12
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 37 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
  --> src/main.rs:32:5
   |
32 | /     match std::env::var("RUST_BACKTRACE") {
33 | |         Err(_) => {
34 | |             std::panic::set_hook(Box::new(panic::hook));
35 | |         }
36 | |         Ok(_) => {}
37 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
   = note: `#[warn(clippy::single_match)]` on by default
help: try
   |
32 ~     if let Err(_) = std::env::var("RUST_BACKTRACE") {
33 +         std::panic::set_hook(Box::new(panic::hook));
34 +     }
   |

Check warning on line 56 in src/input/mapping.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

manual implementation of `Option::map`

warning: manual implementation of `Option::map`
  --> src/input/mapping.rs:49:17
   |
49 | /                 if let Some(id) = button_to_roborio(button) {
50 | |                     Some(JoystickValue::Button {
51 | |                         id,
52 | |                         pressed: value.is_pressed(),
...  |
55 | |                     None
56 | |                 }
   | |_________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
help: try
   |
49 ~                 button_to_roborio(button).map(|id| JoystickValue::Button {
50 +                         id,
51 +                         pressed: value.is_pressed(),
52 +                     })
   |

Check warning on line 27 in src/input/mapping.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

manual implementation of `Option::map`

warning: manual implementation of `Option::map`
  --> src/input/mapping.rs:23:17
   |
23 | /                 if let Some(id) = axis_to_roborio(axis) {
24 | |                     Some((id, value))
25 | |                 } else {
26 | |                     None
27 | |                 }
   | |_________________^ help: try: `axis_to_roborio(axis).map(|id| (id, value))`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
   = note: `#[warn(clippy::manual_map)]` on by default

Check warning on line 9 in src/state.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

field `has_joysticks` is never read

warning: field `has_joysticks` is never read
 --> src/state.rs:9:9
  |
6 | pub struct State {
  |            ----- field in this struct
...
9 |     pub has_joysticks: bool,
  |         ^^^^^^^^^^^^^
  |
  = note: `#[warn(dead_code)]` on by default

Check warning on line 25 in src/panic.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

unused variable: `homepage`

warning: unused variable: `homepage`
  --> src/panic.rs:25:35
   |
25 |     let (_version, name, authors, homepage) =
   |                                   ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_homepage`

Check warning on line 25 in src/panic.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

unused variable: `authors`

warning: unused variable: `authors`
  --> src/panic.rs:25:26
   |
25 |     let (_version, name, authors, homepage) =
   |                          ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_authors`
   |
   = note: `#[warn(unused_variables)]` on by default

Check warning on line 8 in src/panic.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead

warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead
 --> src/panic.rs:8:20
  |
8 | pub fn hook(info: &PanicInfo) {
  |                    ^^^^^^^^^

Check warning on line 4 in src/panic.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead

warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead
 --> src/panic.rs:4:17
  |
4 | use std::panic::PanicInfo;
  |                 ^^^^^^^^^

Check warning on line 6 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead

warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead
 --> src/main.rs:6:17
  |
6 | use std::panic::PanicInfo;
  |                 ^^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

Check warning on line 2 in src/panic.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

unused import: `std::fmt::Result as FmtResult`

warning: unused import: `std::fmt::Result as FmtResult`
 --> src/panic.rs:2:5
  |
2 | use std::fmt::Result as FmtResult;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 10 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

unused imports: `MessageBoxIcon` and `message_box_ok`

warning: unused imports: `MessageBoxIcon` and `message_box_ok`
  --> src/main.rs:10:23
   |
10 | use tinyfiledialogs::{message_box_ok, MessageBoxIcon};
   |                       ^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^

Check warning on line 6 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Ubuntu

unused import: `std::panic::PanicInfo`

warning: unused import: `std::panic::PanicInfo`
 --> src/main.rs:6:5
  |
6 | use std::panic::PanicInfo;
  |     ^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default