Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] 토큰 관리하는 TokenManager 보완사항 #11

Open
2 of 4 tasks
Ojongseok opened this issue Oct 19, 2023 · 2 comments
Open
2 of 4 tasks

[Refactor] 토큰 관리하는 TokenManager 보완사항 #11

Ojongseok opened this issue Oct 19, 2023 · 2 comments

Comments

@Ojongseok
Copy link
Member

Ojongseok commented Oct 19, 2023 •
edited
Loading

Issue

  • 이슈 내용: TokenManager 다른 클래스에 hilt로 주입하고 싶음...

Branch Name

  • 생성 브랜치 이름 : feat/naver_login

To-Do List

  • Activity, Fragment에 생성자로 주입하기(BaseActivity, BaseFragment 생성자때문에 안되는건지...)
  • OkHttp 인터셉터에 Header로 자동으로 전송될 수 있도록 마이그레이션
  • TokenManager에 accessToken collect하는 로직에서 기존 토큰 만료된 경우에 액티비티 두 번 실행되는 버그 있음,,
  • 소셜로그인 로그아웃
@Ojongseok Ojongseok changed the title [Refactor] TokenManager를 Activity, Fragment에 Hilt로 DI [Refactor] 토큰 관리하는 TokenManager 보완사항 Oct 19, 2023
@Ojongseok
Copy link
Member Author

LoginActivity에 몰려있는 자동로그인 로직 SplashActivity에서 체크하도록 일부 옮겨야 할듯

@seunghee17
Copy link
Member

activity나 fragment는 원래 생성자로 주입이 안되지 않나..?

@Ojongseok Ojongseok mentioned this issue Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seunghee17 @Ojongseok