Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

비관적 락 사용한 조회 호출에 대한 재시도 처리 적용 #297

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

vanillacake369
Copy link
Collaborator

@vanillacake369 vanillacake369 commented Mar 17, 2024

개요

비관적 락 사용한 조회 호출하는 메서드가 존재합니다.
여러 스레드가 경합하는 경우, 대기시간에 따라 타임아웃 예외가 발생할 수 있습니다.
따라서 이에 대한 AOP를 적용하여 최대 3회(기본값) 재시도 처리를 하게끔 구현하였습니다.

작업사항

  • SellQueryService 에 @retryable 적용 (delay 100ms 설정)
  • BuyQueryService 에 @retryable 적용 (delay 100ms 설정)

관련 이슈

@vanillacake369 vanillacake369 added the improvement 성능 개선사항입니다. label Mar 17, 2024
@vanillacake369 vanillacake369 self-assigned this Mar 17, 2024
Copy link

Test Results

118 tests   104 ✅  4s ⏱️
 49 suites   14 💤
 49 files      0 ❌

Results for commit 82327ff.

Copy link
Member

@yunjae62 yunjae62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!
SGTM

@vanillacake369 vanillacake369 merged commit 09d3027 into main Mar 19, 2024
2 checks passed
@vanillacake369 vanillacake369 deleted the refactor/add-retry-on-pessimistic-lock branch March 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement 성능 개선사항입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

비관적 락 사용한 조회 호출에 대한 재시도 처리 적용
2 participants