Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProductService -> ProductCommandService, ProductQueryService 로 분리 #235

Merged
merged 1 commit into from
Feb 5, 2024
Merged

ProductService -> ProductCommandService, ProductQueryService 로 분리 #235

merged 1 commit into from
Feb 5, 2024

Conversation

vanillacake369
Copy link
Collaborator

@vanillacake369 vanillacake369 commented Feb 4, 2024 •
edited
Loading

개요

CQRS 가 적용되어있는데 ProductService 가 분리가 되어있지 않아 이슈가 있었습니다. 이에 대해 Command / Query 로 분리했습니다!

image

작업사항

  • ProductService -> ProductCommandService, ProductQueryService 로 분리

관련 이슈

@vanillacake369 vanillacake369 added the bug Something isn't working label Feb 4, 2024
@vanillacake369 vanillacake369 self-assigned this Feb 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2024

Test Results

73 tests   63 ✅  4s ⏱️
34 suites  10 💤
34 files     0 ❌

Results for commit ac3c64a.

@vanillacake369 vanillacake369 marked this pull request as ready for review February 4, 2024 17:05
yunjae62
yunjae62 approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@yunjae62 yunjae62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Binsreoun
Binsreoun approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@Binsreoun Binsreoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@vanillacake369 vanillacake369 merged commit fcd5268 into main Feb 5, 2024
2 checks passed
@vanillacake369 vanillacake369 deleted the fix/test/admin-create-coupon-product branch February 5, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Binsreoun Binsreoun Binsreoun approved these changes

@yunjae62 yunjae62 yunjae62 approved these changes

@Mayst1232 Mayst1232 Awaiting requested review from Mayst1232

Assignees

@vanillacake369 vanillacake369

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProductService -> ProductCommandService, ProductQueryService 로 분리
3 participants
@vanillacake369 @yunjae62 @Binsreoun