Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

주문 시, 구매입찰/판매입찰 조회에 대한 PESSIMISTIC_WRITE 락 걸기 #233

Merged
merged 21 commits into from
Feb 7, 2024
Merged

주문 시, 구매입찰/판매입찰 조회에 대한 PESSIMISTIC_WRITE 락 걸기 #233

merged 21 commits into from
Feb 7, 2024

Conversation

vanillacake369
Copy link
Collaborator

@vanillacake369 vanillacake369 commented Feb 4, 2024 •
edited
Loading

개요

주문 시, 구매입찰/판매입찰 조회에 대하여 Exclusive Lock을 겁니다. 이를 위해 QueryDsl 내에 PESSIMISTIC_WRITE 을 사용하였습니다.

작업사항

  • SellNowRequestDto에 @builder 추가
  • BuyRepositoryCustomImpl 가장 먼저 생성된 구매입찰 조회 시, PESSIMISTIC_WRITE
  • SellRepositoryCustomImpl 가장 나중에 생성된 판매입찰 조회 시, PESSIMISTIC_WRITE

관련 이슈

@vanillacake369
feat : 통합테스트 환경을 위해 application-test.yml 에 REDIS,S3,TOSS,OAuth2 키 추가
668d3f6
@vanillacake369
test : 스레드2500개_동시에_구매입찰생성요청 테스트
ed45769 
- 여러 트랜잭션이 동시에 저장요청 시, optimisticLockTimeOut 이 걸려 예외가 발생
@vanillacake369
test : BuyBidProviderIntegrationTest 구현
89a831c
@vanillacake369
test : BuyBidSaveMultipleThreadTest 구현
acfc13b 
- 2500 개의 구매요청 동시 요청 (통과✅🙆‍♂️)
@vanillacake369
refactor : BaseIntegrationTest 에서 console 출력 제거
3552af7
@vanillacake369
test : BuyBidSaveMultipleThreadTest -> BuyBidSaveConcurrentTest 로 ren…
ca6aaf7 
…aming
@vanillacake369
feat : SellNowRequestDto에 @builder 추가
669e576
@vanillacake369
fix : BuyRepositoryCustomImpl 가장 먼저 생성된 구매입찰 조회 시, PESSIMISTIC_WRITE
16bd59b
@vanillacake369
test : 비동기 Transaction 스레드 마련
b9f09ce
@vanillacake369
test : SellNowConcurrentTest 동일한_판매입찰_동시에_구매입찰생성요청
b1954c0
@vanillacake369
test : BuyBidSaveConcurrentTest 스레드2500개 동시에 구매입찰생성요청
9c2c1fc
@vanillacake369
Merge branch 'main' of https://github.com/Team-BC-1/gream into fix/lo…
c412082 
…ck-when-order-from-bid
@vanillacake369 vanillacake369 self-assigned this Feb 4, 2024
@vanillacake369 vanillacake369 added the bug Something isn't working label Feb 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2024 •
edited
Loading

Test Results

86 tests   72 ✅  4s ⏱️
41 suites  14 💤
41 files     0 ❌

Results for commit f80b53a.

♻️ This comment has been updated with latest results.

@vanillacake369 vanillacake369 marked this pull request as ready for review February 4, 2024 15:49
yunjae62
yunjae62 previously approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@yunjae62 yunjae62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

yunjae62
yunjae62 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@yunjae62 yunjae62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@yunjae62 yunjae62 merged commit d24bd91 into main Feb 7, 2024
2 checks passed
@yunjae62 yunjae62 deleted the fix/deadlock-when-create-buybid branch February 7, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjae62 yunjae62 yunjae62 approved these changes

@Mayst1232 Mayst1232 Awaiting requested review from Mayst1232

@Binsreoun Binsreoun Awaiting requested review from Binsreoun

Assignees

@vanillacake369 vanillacake369

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

주문 시, 구매입찰/판매입찰 조회에 대한 PESSIMISTIC_WRITE 락
2 participants
@vanillacake369 @yunjae62