Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# links to sections on wiki pages don't always work if pasted into comments. #5

Open
ckjpn opened this issue Mar 10, 2020 · 2 comments

Comments

@ckjpn
Copy link

ckjpn commented Mar 10, 2020

The Problem

On a link like this, ...
https://en.wiki.tatoeba.org/articles/show/guidelines#do-not-change-sentences-that-are-correct.

... the final period gets filtered out and is not part of the link on tatoeba.org.

Note that the same thing happens here on GitHub.

Perhaps these are possible solutions.

  • Drop all final punctuation for such links in the wiki.

  • Don't filter out the final punctuation of links on tatoeba.org. This likely will cause problems, since many links will be followed by final punctuation when used in sentences on tatoeba.org, causing bad URLs.

Live Example

https://tatoeba.org/eng/sentences/show/33736#comment-1165051

@jiru
Copy link
Member

jiru commented Mar 13, 2020

It looks to me that this is more of a bug in tatowiki. It should exclude full stops from anchor slugs.

@trang
Copy link
Member

trang commented Mar 14, 2020

I think so too. I will transfer this to tatowiki's issues.

@trang trang transferred this issue from Tatoeba/tatoeba2 Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants