From ca299c47b1646516e481cb9d0a96a5d3fb58bb93 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Chris=20M=C3=BCller?= <2566282+brotkrueml@users.noreply.github.com> Date: Fri, 23 Aug 2024 18:40:40 +0200 Subject: [PATCH] [TASK] Mark properties as private in AdminModuleController As the class is defined as final, it does not make sense to set the properties as protected as this class cannot be extended. Releases: main, 12.4 --- Classes/Controller/AdminModuleController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Classes/Controller/AdminModuleController.php b/Classes/Controller/AdminModuleController.php index cda36e3..1167b68 100644 --- a/Classes/Controller/AdminModuleController.php +++ b/Classes/Controller/AdminModuleController.php @@ -31,8 +31,8 @@ final readonly class AdminModuleController { public function __construct( - protected ModuleTemplateFactory $moduleTemplateFactory, - protected IconFactory $iconFactory, + private ModuleTemplateFactory $moduleTemplateFactory, + private IconFactory $iconFactory, private UriBuilder $uriBuilder, // ... ) {}