From 1d78b7c92bc60b79780b48621c1a9d16804e12ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Fr=C3=B6mken?= Date: Mon, 26 Aug 2024 14:59:11 +0200 Subject: [PATCH] [TASK] Mark properties as private in AdminModuleController (#283) (#284) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [TASK] Mark properties as private in AdminModuleController (#283) As the class is defined as final, it does not make sense to set the properties as protected as this class cannot be extended. Releases: main, 12.4 * Remove empty line from ModuleController --------- Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com> Co-authored-by: Lina Wolf <48202465+linawolf@users.noreply.github.com> --- Classes/Controller/AdminModuleController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Classes/Controller/AdminModuleController.php b/Classes/Controller/AdminModuleController.php index 171394b..343bc05 100644 --- a/Classes/Controller/AdminModuleController.php +++ b/Classes/Controller/AdminModuleController.php @@ -30,8 +30,8 @@ final class AdminModuleController { public function __construct( - protected readonly ModuleTemplateFactory $moduleTemplateFactory, - protected readonly IconFactory $iconFactory, + private readonly ModuleTemplateFactory $moduleTemplateFactory, + private readonly IconFactory $iconFactory, // ... ) {}