Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fourier transform for bosons is not implemented #66

Open
krivenko opened this issue May 27, 2012 · 6 comments
Open

Fourier transform for bosons is not implemented #66

krivenko opened this issue May 27, 2012 · 6 comments

Comments

@krivenko
Copy link
Contributor

Comments in triqs/gf_local/fourier.cpp say that 'Boson not implemented'. Is there a technical reason which makes the implementation considerably harder than for fermions?
I can try to write the code (probably I'm among not so many people who really need it) and would appreciate suggestions/cautions concerning it.

@parcollet
Copy link
Member

The only reason is that we did not use it yet (I used it a lot in the past, before TRIQS ...).
How to do it ? It should be "almost" done, the assert is there because it has not been tested, I think.
I will check and get back to you, or @mferrero will...

@mferrero
Copy link
Member

mferrero commented Jun 2, 2012

@krivenko : Leonid needed that Fourier transform and he implemented and tested it. It is in the main repository now. But it would be very useful if you could test it as well. Let us know! It is commit 07b2bfb.

@krivenko
Copy link
Contributor Author

@mferrero : I will test it soon in the context of my slave rotors code and close the issue if it works.

@mferrero
Copy link
Member

I found a small mistake in the Fourier. I fixed it in commit 476c192. Some tests should be added to test all these Fourier transforms.

@mferrero
Copy link
Member

mferrero commented Jul 4, 2012

@krivenko : Did you have a chance to try the bosonic Fourier transforms? I did a couple of easy tests and it looked like it was working.

@krivenko
Copy link
Contributor Author

krivenko commented Jul 4, 2012

@mferrero Sorry, didn't try yet. But if you are sure it's functional feel free to close the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants