Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triqs application stops compiling when reinstalling triqs/1.3.x on same commit #976

Open
HugoStrand opened this issue Dec 13, 2024 · 0 comments

Comments

@HugoStrand
Copy link
Member

Description

Triqs currently clones library dependencies nda, h5, based on branches. This causes "silent failures" when a library introduces bugs that breaks a Triqs application, see e.g. TRIQS/cpp2py#57

Could you please add fixed commits in the call to the external_dependency cmake function for all external libraries, orchestrated here https://github.com/TRIQS/triqs/blob/3.3.x/deps/CMakeLists.txt#L112 ?

This would stop this kind of silent change of behaviour of Triqs (through changes in the libraries) when building a certain commit. (I understand that this might not be the way to go for the unstable branch, but for release branches like 1.3.x I think it would be great help to applications developers.)

Best, Hugo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant