HTML5 Report: Accumulate tags

[clementheliou]

Currently, we can select scenarios related to one given tag by clicking on it.
But we're not able to select scenarios related to a selection of tags.

Let's say we have these tags:

• Customer -> this a high-level feature tag;
• Account -> this is a more specific feature tag that could be used inside another high-level feature;
• Listed -> this is a customer specificity that could be used inside another high-level feature.

If I filter scenarios by one of these tags, I do not have the ones I'm looking for.
A possible solution would be the accumulation of tags: Customer AND Account AND Listed.
We could also think about a more flexible mechanism language: Customer AND (Account OR Listed).

[janschaefer]

Regarding the AND case you can currently use the search for that, because it will search for all occurrences. The OR case is not possible yet. It could be solved using an improved client-side search engine (see #53).

[clementheliou]

Regarding the AND case, the search feature is incomplete.
It returns the scenarios having both the three tags but also the ones having only one (or two) of them, which is undesired.

Will this use case be solved using an improved client-side search engine?

[janschaefer]

Are you sure? For example, if I search for 'Tags JUnit' I only get scenarios which have 'Tags' and 'JUnit':

http://jgiven.org/jgiven-report/html5/#/search/Tags%20JUnit

[clementheliou]

Ok, I got it!
My tags have spaces in their values and share a common part.

• Account Management
• Account Administration

If I search for 'Customer Account Management Listed', it also returns the scenarios with 'Account Administration' tag.

[janschaefer]

Ok. I see :-)

[janschaefer]

Created #82 for searching for words with whitespace

[janschaefer]

Do you think this issue can be closed now with the introduction of filtering by tags?

[clementheliou]

Intrinsically, the filtering by tags feature resolves this issue.
However, there is some kind of troubleshooting with it.

Let's try with the JGiven documentation: http://jgiven.org/jgiven-report/html5/#/tag/Feature/JUnit
Randomly, scenarios are not updated with the selected tags (for examples Tags & TestNG).

[janschaefer]

Mmh. For me it works as (I) expected. Could you explain in more detail what is wrong?

[clementheliou]

Let's say I'm looking at the JUnit feature: http://jgiven.org/jgiven-report/html5/#/tag/Feature/JUnit
When I accumulate/select the Tags & TestNG values inside the Tags dropdown, the displayed scenarios are not always updated. That means, randomly, unrelated scenarios are still displayed.

It looks like a refresh issue but seems to appears randomly.

[janschaefer]

Ok. That is strange and should not happen ;-). Which browser are you using?

[clementheliou]

I'm using Chrome version 38.0.2125.104

[janschaefer]

With Chrome 43.0.2357.125 on Linux, I cannot reproduce it. Could you please test it in another browser to see whether this is browser-specific? And could you take a screenshot of the wrong page?

[clementheliou]

I can reproduce this behavior with Firefox 24.1.1 ESR.
See below a screenshot.

[janschaefer]

Ok. Beside the fact that the layout is not that good, because of the smaller window size (that should be fixed) this is what I also see :-). Maybe we have a different understanding of what should be shown. The point is that the selection of tags is actually an 'or' relation and not an 'and' relation. Thus if you select 'Tags' and 'TestNG' you will see all scenarios that have either the 'Tags' tag or the 'TestNG' tag or both. But I see that this might be confusing. Do you think it would make more sense to have an 'and' relation?

[janschaefer]

Actually I must admit that I wanted to follow the GitHub behavior when using labels. Somehow I thought that this was an or-relation, but actually it is an and-relation. So I guess using an and-relation is more intuitive.

[clementheliou]

I was expecting an and-relation but I have to admit that using the or one is also a valid scenario.
If you decide to add the and-relation, this issue could be closed.

[janschaefer]

Ok. I will have to think about that :-)

[janschaefer]

For now I decided to change the or to an and-relation, because it is typically the case that you want to narrow down the number of scenarios. The change will be in v0.8.0.

[clementheliou]

Nice! Thanks.

[Airblader]

@janschaefer What is the status of this? It almost sounds like this has been "fixed", but there's no linked commits or information on what else would have to be done.

[janschaefer]

Maybe I really forgot to close this issue :-). @clementheliou do you think we can close this?

[clementheliou]

@janschaefer Yes, you can.
This issue has been fixed a long time ago with the switch from the OR relation to the AND one.

[janschaefer]

Great thx!