Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Address Relationship #47

Open
drewroberts opened this issue Mar 21, 2021 · 0 comments
Open

Email Address Relationship #47

drewroberts opened this issue Mar 21, 2021 · 0 comments
Assignees

Comments

@drewroberts
Copy link
Member

With the creation of the new Email Addresses model (TIPOFF/authorization#57), all string fields for email in this package should be replaced with a findOrCreate() relationship with that model. We can use the app('email_address') & nova('email_address') helpers added in release 1.8.3 of tipoff/support.

In addition to changing the database migrations, we should also update the model, factory, and nova resource. Later, we will have a custom nova field (TIPOFF/authorization#59) for our usage of Email Address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants