Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plugin for OMP #126

Open
nuest opened this issue Jul 31, 2023 · 0 comments
Open

Fix Plugin for OMP #126

nuest opened this issue Jul 31, 2023 · 0 comments
Labels
OMP Open Manuscript Press-related issues

Comments

@nuest
Copy link
Collaborator

nuest commented Jul 31, 2023

(Recording the results of a previous internal evaluation:)

  • Both plugins can be installed and activated without errors
  • Showing the map in the submission works
  • Saving the submission does not work.

image

Error:

[Mon Jul 31 14:33:00 2023] PHP Fatal error:  Uncaught Error: Call to undefined method Request::getJournal() in /home/daniel/git/OPTIMETA/optimetaGeo/OptimetaGeoPlugin.inc.php:546

Stack trace:

#0 /home/daniel/git/OPTIMETA/omp-3.3.0-14/lib/pkp/classes/plugins/HookRegistry.inc.php(107): OptimetaGeoPlugin->editPublication()

#1 /home/daniel/git/OPTIMETA/omp-3.3.0-14/lib/pkp/classes/services/PKPPublicationService.inc.php(524): HookRegistry::call()

#2 /home/daniel/git/OPTIMETA/omp-3.3.0-14/lib/pkp/classes/submission/PKPSubmissionMetadataFormImplementation.inc.php(196): PKP\Services\PKPPublicationService->edit()

#3 /home/daniel/git/OPTIMETA/omp-3.3.0-14/lib/pkp/classes/submission/form/PKPSubmissionSubmitStep3Form.inc.php(100): PKPSubmissionMetadataFormImplementation->execute()

#4 /home/daniel/git/OPTIMETA/omp-3.3.0-14/lib/pkp/pages/submission/PKPSubmissionHandler.inc.php(177): PKPSubmissionSubmitStep3Form->execute()

#5 /home/daniel/git/OPTIMETA/omp-3.3.0-14/lib/pkp/classes/core/PKPRouter.inc.php(395): PKPSubmissionHandler->saveStep()

#6 /home/daniel/git/OPTIMETA/omp-3.3.0-14/lib/pkp/classes/core/PKPPageRouter.inc.php(246): PKPRouter->_authorizeInitializeAndCallRequest()

#7 /home/daniel/git/OPTIMETA/omp-3.3.0-14/lib/pkp/classes/core/Dispatcher.inc.php(144): PKPPageRouter->route()

#8 /home/daniel/git/OPTIMETA/omp-3.3.0-14/lib/pkp/classes/core/PKPApplication.inc.php(362): Dispatcher->dispatch()

#9 /home/daniel/git/OPTIMETA/omp-3.3.0-14/index.php(64): PKPApplication->execute()

#10 {main}

  thrown in /home/daniel/git/OPTIMETA/optimetaGeo/OptimetaGeoPlugin.inc.php on line 546

Because OMP does not have the internal artefact "Journal", different

Similar to OPS (see #125 ) the hook names are also different and require conditional checking and usage.

  • Templates::Catalog::Book::Main instead of Templates::Article::Main
  • Templates::Catalog::Book::Details instead of Templates::Article::Details
@nuest nuest added the OMP Open Manuscript Press-related issues label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OMP Open Manuscript Press-related issues
Projects
None yet
Development

No branches or pull requests

1 participant