Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage and improve performance. #409

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yoseph-phillips
Copy link

Reduce memory usage and improve performance.

Most important enhancement is in setDependentElements()
If A is dependent on B and B is dependent on C then A does not need to be dependent on C.

moveDependantElements()
Moves common calculations out of the loop and removes the nested call to moveDependantElements()

Breaks early in the prepareElements() loop if no further work is required.

@lalo-mx
Copy link

lalo-mx commented Dec 22, 2023

Consider keeping the previous formatting style, more easy to review

@yoseph-phillips
Copy link
Author

Consider keeping the previous formatting style, more easy to review

Formatting was the same except that my IDE had replaced tabs with spaces.
I have made it replace the spaces with tabs again so that people don't need to click on ignore whitespace in GitHub when reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants