Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate on using docker compose in dev mode #3521

Open
alecthomas opened this issue Nov 26, 2024 · 1 comment · May be fixed by #3554
Open

Consolidate on using docker compose in dev mode #3521

alecthomas opened this issue Nov 26, 2024 · 1 comment · May be fixed by #3554
Assignees

Comments

@alecthomas
Copy link
Collaborator

We now have two paths to creating Docker containers - our own imperative functions, and one using docker compose. We should consolidate on one, and docker compose seems like the way to go.

We can also eliminate our customer "readiness" function and replace it with health checks, eg.

    healthcheck:
      test: ["CMD-SHELL", "pg_isready"]
      interval: 1s
      timeout: 60s
      retries: 60
      start_period: 80s
@matt2e
Copy link
Collaborator

matt2e commented Nov 26, 2024

  • Centralise logic so others call into it
  • Use flocks to prevent multiple of the same type at once (rather than locks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants