Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths config doesn't validate on close #4077

Open
YoshiRulz opened this issue Oct 4, 2024 · 1 comment
Open

Paths config doesn't validate on close #4077

YoshiRulz opened this issue Oct 4, 2024 · 1 comment
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements

Comments

@YoshiRulz
Copy link
Member

Should maybe validate at the top of this loop:

foreach (var t in AllPathControls.OfType<TextBox>())
{
var pathEntry = _pathEntries.Paths.First(p => p.System == t.Parent.Name && p.Type == t.Name);
pathEntry.Path = t.Text;
}

Initially reported by @Spikestuff on Discord.

@YoshiRulz YoshiRulz added App: EmuHawk Relating to EmuHawk frontend Repro: Affects 2.10 dev labels Oct 4, 2024
@Morilli
Copy link
Collaborator

Morilli commented Oct 4, 2024

Perhaps it should also explicitly allow the case that caused this report; having an otherwise valid path enclosed in "".

Morilli added a commit that referenced this issue Oct 5, 2024
@YoshiRulz YoshiRulz added Enhancement For feature requests or possible improvements and removed Repro: Affects 2.10 dev labels Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements
Projects
None yet
Development

No branches or pull requests

2 participants