Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Support for Old Setting Names #842

Open
wesleyboar opened this issue Jul 5, 2024 · 1 comment
Open

Remove Support for Old Setting Names #842

wesleyboar opened this issue Jul 5, 2024 · 1 comment
Labels
proposal Proposal or request for new task

Comments

@wesleyboar
Copy link
Member

Complaint

Too much code for old setting names that are not used anymore.

Proposal

Remove the code for old setting names.

Alternative

Ignore unused code.

Proof

In TACC/Core-Portal-Deployments@30a41f6, the old setting names are not used:

SEARCH_ TACC_ INCLUDES FAVICON
SEARCH_ TACC_ INCLUDES_ FAVICON
replaced by PORTAL_SEARCH_ only active settings are present replaced by PORTAL_IS_/PORTAL_HAS_ replaced by PORTAL_FAVICON
@wesleyboar
Copy link
Member Author

Technically, removing backwards-compatibility is a breaking change (i.e. an incompatible API change), so I suggest doing this only for v5 release. The v5 release would likely come when Core-CMS uses Django v5.

@wesleyboar wesleyboar added the proposal Proposal or request for new task label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal Proposal or request for new task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wesleyboar