Header Redesign → FP-1458 #101

wesleyboar · 2021-01-29T14:41:53Z

Status

Migrated to FP-1458.

Goal

Update header style to match newest design.
Use Cortal icons (FP-526: Install Header Cortal Icons).

Direction

Unless requested, avoid performing technical debt and nice to haves, like:

The styles are not ideal, but there are maintainable. The markup is duplicated, but the duplication is much less than it was before you took over.

Reference

(Confluence) Shared UI - Components - Header (see "Mid 2021")
(Adobe XD) CMS-Common Components
If you need custom navbar transisitons instead of Bootstrap's…
- Turning off Twitter Bootstrap Navbar Transition animation
- Responsive Animated Navbar with CSS

- Migrate `branding_logos` CSS to `c-branding` & `c-logo`. - In `s-header` style `.c-logo` not `.navbar-brand` . - Update and format markup for `header_branding` and `header_logo`. - Comment on now-unused secrets values.

- Migrate `branding_logos` CSS to `c-branding` & `c-logo`. - In `s-header` style `.c-logo` not `.navbar-brand`. - Update and format markup for `header_branding` and `header_logo`. - Comment on now-unused secrets values.

…riables

…design--branding-bar

…ng-bar GH-101: Branding Bar

- Remove now-moot taccsite_custom:frontera-cms search bar font sizes. - Support CSS custom selectors (known external bug). - Test CSS custom selectors (known external bug). - Remove outdated comment from `c-branding`. - Set `c-logo` image height in component stylesheet. - Add TODO for `html { font-size: 62.5%; }` - Add arrow "mixin" (note: using `%-arrow` syntax). - Redesign header (but not dropdowns and not portal nav). - Remove now-moot `s-portal-nav` styles. - Add & Update header env variables for themes. - Perform "GH-129: Do Not Support CMS Menu Nav Link & Dropdown".

Prevent dropdown link from being flagged as active.

- (Real Fix) Ensure colors are available to Docs. - (Possible Fix) Ensure correct colors are available to Portal.\* \* The Portal has its own settings/color.css that is almost identical.

- Load new styles solely for docs header. - Force branding styles on old markup. - Migrate subsite selectors from `trumps/s-header` to `tools/selectors`. - Rename `:--in-__subsite__` selectors to `:--from-__subsite__`. - Create new styles solely for docs header. - Document "For (Other Sites)" i.e. `trumps/for-docs.*.css` stylesheets.

Unset Docs' `img { max-width; }`. Docs does this too but for old markup.

- Install `merge-lite` for deep merge constants and theme data. - Use env() vars for header height. - Remove unnecessary code and improve comments. - Create constants for theme JSON. - Merge constants on top of theme data. - Update theme data comment syntax.

CAVEAT: Font is not always consistent between states and sites.

CAVEAT: The mobile nav menus have not yet been moved ot their new position in the design.

…design--mobile-nav-layout-2

…ask/GH-101-header-redesign

…design--mobile-nav-layout-2

I am suprised more branches aren't failing, given that this caused a server crash on task/GH-101.

…design--mobile-nav-layout-2

Known Issues: 1. On CMS & Docs, `s-header__menu-backdrop` adds gap in navigation bar. 2. On CMS, mobile navbar opens and closes too slow. 3. login link is a bit too wide

Known Issues: 1. On CMS & Docs, `s-header__menu-backdrop` adds gap in navigation bar. 2. On CMS, mobile navbar opens and closes too slow. 3. The login link is a bit too wide. 4. Code is difficult to follow (but documented).

…ask/GH-101-header-redesign

…design--mobile-nav-layout-2

wesleyboar · 2023-08-29T03:50:50Z

Migrated to JIRA as FP-1458 a long time ago.

wesleyboar added enhancement Improvements or additions to existing features priority ▼ Low priority effort S Small effort task (~½ a week) — does not include review time tacc labels Jan 29, 2021

wesleyboar added the ⓣ frontera phase 1 label Feb 5, 2021

wesleyboar added this to the Frontera CMS Redesign - Phase 1 milestone Feb 5, 2021

wesleyboar removed ⓣ frontera phase 1 labels Feb 5, 2021

wesleyboar added priority ▲ High priority and removed priority ▼ Low priority labels Apr 22, 2021

wesleyboar mentioned this issue Apr 27, 2021

GH-195: Clone Portal Nav #211

Merged

wesleyboar mentioned this issue May 11, 2021

Resize "Brand Bar" and "Nav Bar" #29

Closed

This was referenced May 12, 2021

GH-191: Theme (for ProTX Light Header & TACC Blue Header) #192

Merged

GH-101: Environment Variables for CSS #221

Merged

wesleyboar added a commit that referenced this issue May 12, 2021

Merge pull request #221 from TACC/task/GH-101-header-redesign--env-va…

03a9482

…riables

wesleyboar added a commit that referenced this issue May 13, 2021

Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…

4533c5f

…design--branding-bar

wesleyboar added a commit that referenced this issue May 13, 2021

Merge pull request #220 from TACC/task/GH-101-header-redesign--brandi…

80ed3c0

…ng-bar GH-101: Branding Bar

This was linked to pull requests May 13, 2021

GH-101: Branding Bar #220

Merged

GH-101/FP-1458: Header Redesign #222

Draft

wesleyboar mentioned this issue May 13, 2021

Do Not Support CMS Menu Dropdown Nav Link #129

Closed

wesleyboar added a commit that referenced this issue May 14, 2021

GH-101: Navigation Bar (Fix CMS Nav Bug in Docs)

a9ec66a

Prevent dropdown link from being flagged as active.

wesleyboar added a commit that referenced this issue May 14, 2021

GH-101: Navigation Bar (Fix Img Max-Width in Docs)

290e27b

Unset Docs' `img { max-width; }`. Docs does this too but for old markup.

wesleyboar added a commit that referenced this issue May 14, 2021

GH-101: Navigation Bar (Fix & Doc Height Bugs)

d3361d7

wesleyboar added a commit that referenced this issue May 14, 2021

GH-101: Navigation Bar (Set Dropdown Font Size)

ccfc596

wesleyboar added a commit that referenced this issue Aug 17, 2021

Merge branch 'main' into task/GH-101-header-redesign

deec8d9

wesleyboar added a commit that referenced this issue Aug 18, 2021

GH-101: Refactor Portal Link Fixes 758e2ff

1614594

CAVEAT: Font is not always consistent between states and sites.

wesleyboar added a commit that referenced this issue Aug 19, 2021

GH-101: Fix: Remove core portal logo's whitespace

a7d9eed

wesleyboar added a commit that referenced this issue Aug 19, 2021

GH-101: Move Portal Nav out of expanding navbar

245f21b

CAVEAT: The mobile nav menus have not yet been moved ot their new position in the design.

wesleyboar added a commit that referenced this issue Aug 19, 2021

GH-101: Move Portal Nav out of expanding navbar

46e2a49

CAVEAT: The mobile nav menus have not yet been moved ot their new position in the design.

wesleyboar added a commit that referenced this issue Aug 20, 2021

Merge branch 'main' into task/GH-101-header-redesign

e165cc2

wesleyboar added a commit that referenced this issue Aug 20, 2021

Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…

7cf8137

…design--mobile-nav-layout-2

wesleyboar added a commit that referenced this issue Aug 23, 2021

Merge branch 'task/GH-191-support-light-navbar-for-dark-logos' into t…

c31b7e6

…ask/GH-101-header-redesign

wesleyboar added a commit that referenced this issue Aug 23, 2021

Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…

bc09ec8

…design--mobile-nav-layout-2

wesleyboar added a commit that referenced this issue Sep 2, 2021

GH-101: Build settings.json before CSS

fe9de08

wesleyboar added a commit that referenced this issue Sep 2, 2021

Quick: Remove errant comma in settings

2498c27

I am suprised more branches aren't failing, given that this caused a server crash on task/GH-101.

wesleyboar added a commit that referenced this issue Sep 2, 2021

Merge branch 'main' into task/GH-101-header-redesign

6401683

wesleyboar added a commit that referenced this issue Sep 2, 2021

Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…

3a5c088

…design--mobile-nav-layout-2

wesleyboar added a commit that referenced this issue Sep 9, 2021

GH-101: New mobile portal and nav menu design

73ddd2e

Known Issues: 1. On CMS & Docs, `s-header__menu-backdrop` adds gap in navigation bar. 2. On CMS, mobile navbar opens and closes too slow. 3. login link is a bit too wide

wesleyboar added a commit that referenced this issue Sep 10, 2021

GH-101: Add TODO.md to track remaining work

c738a6a

wesleyboar added a commit that referenced this issue Sep 21, 2021

Merge branch 'task/GH-191-support-light-navbar-for-dark-logos' into t…

2e4c19f

…ask/GH-101-header-redesign

wesleyboar added a commit that referenced this issue Sep 23, 2021

Merge branch 'main' into task/GH-101-header-redesign

b786c3c

wesleyboar added a commit that referenced this issue Sep 23, 2021

Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…

403567c

…design--mobile-nav-layout-2

wesleyboar added a commit that referenced this issue Sep 27, 2021

Merge branch 'main' into task/GH-101-header-redesign

73e6190

wesleyboar mentioned this issue Oct 26, 2021

Quick: Complete Core fix for section header colors #385

Merged

wesleyboar added a commit that referenced this issue Nov 4, 2021

Merge branch 'main' into task/GH-101-header-redesign

9d5c68a

wesleyboar added the jira label Jan 12, 2022

wesleyboar changed the title ~~Header Redesign~~ Header Redesign → FP-1458 Jan 12, 2022

wesleyboar mentioned this issue Apr 28, 2022

fix(tup-231): move some core-styles back to core-cms TACC/Core-Styles#17

Merged

wesleyboar mentioned this issue Oct 21, 2022

feat(tup-cms): tup-348 portal nav TACC/tup-ui#58

Merged

wesleyboar closed this as completed Aug 29, 2023

wesleyboar unpinned this issue Aug 30, 2023

wesleyboar mentioned this issue Mar 25, 2024

GH-101/FP-1458: Header Redesign #222 - Mobile Nav Layout 2 #824

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Header Redesign → FP-1458 #101

Header Redesign → FP-1458 #101

wesleyboar commented Jan 29, 2021 •

edited

Loading

wesleyboar commented Aug 29, 2023

Header Redesign → FP-1458 #101

Header Redesign → FP-1458 #101

Comments

wesleyboar commented Jan 29, 2021 • edited Loading

Status

Goal

Direction

Reference

wesleyboar commented Aug 29, 2023

wesleyboar commented Jan 29, 2021 •

edited

Loading