Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Actor "token" property #13

Open
mwvaughn opened this issue Aug 7, 2019 · 0 comments
Open

Add support for Actor "token" property #13

mwvaughn opened this issue Aug 7, 2019 · 0 comments
Assignees
@mwvaughn
Labels
enhancement New feature or request test please Need help validating a feature or fix
Milestone
v1.3.0

Comments

@mwvaughn
Copy link

mwvaughn commented Aug 7, 2019

New in Abaco 1.3.0 is a setting that allows users to toggle automatic generation of Oauth tokens at Actor execution. If this is turned off for an actor, it is no longer possible to (automatically) make scripted Tapis API calls, but startup time is reduced substantially since there is no roundtrip to the Tapis /token endpoint to fetch an access token.

This needs to be supported in the CLI as follows:

  • In reactor.rc, the REACTOR_ISSUE_TOKEN variable sets behavior for the project.
    • Default is 1 or True.
  • In abaco init we must add a line for REACTOR_ISSUE_TOKEN to the templated reactor.rc file
  • In abaco create support -A to disable token issuance
  • In abaco deploysupport -A > REACTOR_ISSUE_TOKEN to manage token issuance
@mwvaughn mwvaughn added the enhancement New feature or request label Aug 7, 2019
@mwvaughn mwvaughn self-assigned this Aug 7, 2019
@mwvaughn mwvaughn added this to the v1.3.0 milestone Aug 7, 2019
mwvaughn added a commit that referenced this issue Aug 8, 2019
@mwvaughn
Added support for actor "token" property
f1736d4 
The 'abaco init', 'abaco create', 'abaco update', and 'abaco deploy' commands now support the
'token' property for Actors, which governs whether an actor's executions are populated with
Tapis access tokens. The registration-time and project default behaviors can be tweaked via
combinations of the 'REACTOR_TOKENS' config variable and the '-A' command line flag.

This resolves issue #13
@mwvaughn mwvaughn added the test please Need help validating a feature or fix label Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwvaughn mwvaughn

Labels
enhancement New feature or request test please Need help validating a feature or fix
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
1 participant
@mwvaughn