-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there an ETA when ta-lib will work under C++ 17.0 ? #142
Comments
mrjbq7/ta-lib is just a (cpython) wrapper around the ta-lib.org (C,C++) library you're compiling. This repository doesn't handle the ta-lib.org lib itself. Also it's been pretty abandoned for a while (the lib side) unless someone has move it to github and forked off and kept up its development. |
You could always install the prior version of Visual C++ to get it to compile. |
Another alternative would be to simply use a VM or docker instance to install ta-lib as it's in most popular linux repositories now. But you'd have to work on your software inside either option. |
@mrjbq7 perhaps I should update the Readme with more apt instructions on installing with the windows environment? |
Sure, that would be great. Also, there is a PR to include the |
I see 840 hits, in a variety of languages at GH ... the question becomes: which one of more is active and viable? |
@mrjbq7 I wouldn't combine and mix. |
@herrold There is a ton of wrappers... I don't know of anyone who has moved ta-lib's sources to github and are actively maintaining them. |
Closest maintained fork I can find is: And it's mostly just trying to clean up the mess I explained. They reimplemented the swig and perl apis. But their still more difficult to work with than this lib. I used to work on the swig interface back in the day trying to do exactly what their doing. |
@a904guy concur that this looks like the most vaible of the 840 or so matches which trawling through the GH search tool. The other useful link is a automated import of the prior SF variant, at: The two trees are quite close: [herrold@centos-7 git]$ diff -u svn2github/ta-lib/ta-lib trufanov-nok/ta-lib-rt/ta-lib-rt with the big change in, unsurprisingly, ./ta-lib/ which adds a couple of new functions, and as you mention addresses some build differences [herrold@centos-7 git]$ diff -u svn2github/ta-lib/ta-lib/ta-lib/ trufanov-nok/ta-lib-rt/ta-lib-rt/ta-lib/ | wc -l [herrold@centos-7 git]$ diff -u svn2github/ta-lib/ta-lib/ta-lib/ trufanov-nok/ta-lib-rt/ta-lib-rt/ta-lib/ | grep "^+"
+++ trufanov-nok/ta-lib-rt/ta-lib-rt/ta-lib/ta_func_api.xml 2017-05-01 17:37:10.902498641 -0400
+++ trufanov-nok/ta-lib-rt/ta-lib-rt/ta-lib/ta_func_list.txt 2017-05-01 17:37:10.912493641 -0400 |
I would concur. RT appears the be the only forward motion development on the ta-lib at the moment. |
If you read through their goals of the repo, it was to bring it back up to date (or try too), and add in stored state values, so that it was no longer a stateless library. Which I would consider a mistake, but shrugs |
Would you please try this in your CMD(#135): pip install wheel
git clone -b build-from-source https://github.com/mckelvin/python-ta-lib.git python-ta-lib
cd python-ta-lib
# Do not run `pip install .` here directly
pip wheel .
pip install TA_Lib-0.4.10-cp27-cp27m-win_amd64.whl |
Another possible way is to use Conda: |
@a904guy I agree, the ta-lib code is so messy that I cannot even read them. I tried to start to read it for about 5 times LoL, but each time I have to stop at about 10% ... Maybe it is the time to consider to build our own TA library from scratch. |
@mrjbq7 is working on a pure python conversion.
…On Wed, May 17, 2017 at 4:15 AM braindevices ***@***.***> wrote:
@a904guy <https://github.com/a904guy> I agree, the ta-lib code is so
messy that I cannot even read them. I tried to start to read it for about 5
times LoL, but each time I have to stop at about 10% ... Maybe it is the
time to consider to build our own TA library from scratch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#142 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAYqcXbjtUjN-OEqMrYJl1UarXOsyIWSks5r6qywgaJpZM4NMwwL>
.
|
Closing old issue. |
When trying to create and install the ta-lib 64 bit version, I received an error message "Visual C++ 14.0 is required". Upon further investigation, I noticed that Visual Studio 2017 installs Visual C++ 17.0 and not 14.0. So I then installed C++ 14.0 under 2017, but it's now throwing an "error in script usage" when I run vcvarsall.bat amd64.
So before I spend too much time trying to figure out how to resolve this matter, I thought I would check to see if there is any ETA on when ta-lib will be able to work under C++ 17.0 and not require 14.0.
The text was updated successfully, but these errors were encountered: