Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUPERT) Supertrend indicator #9

Open
mario4tier opened this issue Nov 8, 2024 · 1 comment
Open

(SUPERT) Supertrend indicator #9

mario4tier opened this issue Nov 8, 2024 · 1 comment

Comments

@mario4tier
Copy link
Member

mario4tier commented Nov 8, 2024

@chadfurman when time will come... it seems fairly easy to implement.

https://www.tradingview.com/support/solutions/43000634738-supertrend

TODO before starting: find a reference to validate against.

Details

  • Start with cut&paste&modify of ATR interface from table_a.c into table_s.c
  • Do gen_code a first time (to create ta_SUPERTREND.c)
  • Copy ta_ATR.c "logic" into ta_SUPERTREND.c
  • Modify table_s.c for one more input (the multiplier), two output bands and one trend direction array (<0 when downtrend, >0 when uptrend).
  • Do gen_code again.
  • Add the logic specific to Supertrend.
  • Add regression tests (I can do that part, or use again ATR as a model).
@mario4tier mario4tier transferred this issue from TA-Lib/ta-lib Dec 6, 2024
@mario4tier mario4tier changed the title Add supertrend indicator (SUPERT) Supertrend indicator Dec 6, 2024
@mario4tier mario4tier moved this to Proposal in New TA Functions Dec 6, 2024
@chadfurman
Copy link

Oooh! I love this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposal
Development

No branches or pull requests

2 participants