Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action not performed (or only not logged) on ship's destruction #93

Open
Nevith opened this issue Jan 21, 2018 · 1 comment
Open

Action not performed (or only not logged) on ship's destruction #93

Nevith opened this issue Jan 21, 2018 · 1 comment

Comments

@Nevith
Copy link
Member

Nevith commented Jan 21, 2018

If player ship is destroyed it doesn't perform the action given to it that turn or the action isn't shown in log

@Nevith Nevith added this to the Backlog milestone Jan 21, 2018
@jonpas jonpas removed the bug label Jan 21, 2018
@jonpas jonpas changed the title Combat log and ship destroying Action not performed (or only not logged) on ship's destruction Jan 21, 2018
@jonpas
Copy link
Member

jonpas commented Jan 21, 2018

Turn ends before action effects are actually set, thus enemy does not get effects applied before end of turn and has a chance to do an action before. This is caused because of quick fixing of OnEnd/BeginPerform(), OnEndPerform() gets called from parent before target action calls its ApplyEffectsTarget().

This is not a problem for self-effects, as ApplyEffectsSelf() is executed from root Action class before OnEndPerform(). Target actions add it after-wards though. Needs a bit of redesign, so assigning myself.

@jonpas jonpas self-assigned this Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants