Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Position and Debt repayment on Base #68

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Conversation

peiman3
Copy link
Contributor

@peiman3 peiman3 commented Nov 25, 2024

No description provided.

@peiman3 peiman3 added the enhancement New feature or request label Nov 25, 2024
@peiman3 peiman3 self-assigned this Nov 25, 2024
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 3:14am

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.00%. Comparing base (deaac78) to head (87f9372).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...idity/lib/contracts/importers/importDebtRepayer.js 50.00% 1 Missing ⚠️
...legateBaseAndromeda/useUndelegateBaseAndromeda.tsx 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   59.19%   61.00%   +1.81%     
==========================================
  Files         280      280              
  Lines        6538     6547       +9     
  Branches     2095     2109      +14     
==========================================
+ Hits         3870     3994     +124     
+ Misses       2668     2553     -115     
Files with missing lines Coverage Δ
...ity/components/UndelegateModal/UndelegateModal.tsx 90.36% <100.00%> (+11.69%) ⬆️
...quidity/components/WithdrawModal/WithdrawModal.tsx 79.12% <ø> (+32.96%) ⬆️
liquidity/lib/useClearDebt/useClearDebt.tsx 91.48% <100.00%> (+0.37%) ⬆️
.../ui/src/components/ClosePosition/ClosePosition.tsx 70.14% <100.00%> (ø)
...onents/ClosePosition/ClosePositionTransactions.tsx 77.14% <100.00%> (+9.55%) ⬆️
liquidity/ui/src/components/Deposit/Deposit.tsx 94.11% <100.00%> (+2.75%) ⬆️
liquidity/ui/src/components/Repay/RepayAllDebt.tsx 100.00% <100.00%> (ø)
...uidity/ui/src/components/Undelegate/Undelegate.tsx 89.04% <100.00%> (-0.15%) ⬇️
...idity/lib/contracts/importers/importDebtRepayer.js 80.00% <50.00%> (ø)
...legateBaseAndromeda/useUndelegateBaseAndromeda.tsx 90.19% <93.75%> (+3.40%) ⬆️

... and 6 files with indirect coverage changes

@noisekit noisekit merged commit f7baf82 into master Nov 28, 2024
13 checks passed
@noisekit noisekit deleted the base-close-position branch November 28, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants