Fix invalid pools page loading #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
noisekit
reviewed
Nov 13, 2024
| @@ -51,7 +51,9 @@ export const PositionTitle: FC<{ | |||
| display="flex" | |||
| alignItems="center" | |||
| _hover={{ cursor: 'pointer' }} | |||
| onClick={() => navigate(`/pools/${network?.id}/${poolId}`)} | |||
| onClick={() => | |||
There was a problem hiding this comment.
we need to send people to the pool. not just ignore clicks.
noisekit
reviewed
Nov 13, 2024
noisekit
reviewed
Nov 13, 2024
noisekit
reviewed
Nov 13, 2024
noisekit
force-pushed
the
fix/pools-loading
branch
from
f0fe26e
to
5147fdc
Compare
noisekit
reviewed
Nov 26, 2024
| const params = useParams(); | ||
|
|
||
| const { network: connectedNetwork } = useNetwork(); | ||
| const networkId = params.networkId ? Number(params.networkId) : connectedNetwork?.id; |
There was a problem hiding this comment.
pool header could have been rendered from pages with networkId param and also from position page which did not have networkId param (network is taken from connected wallet)
Now it is proper fixed
noisekit
force-pushed
the
fix/pools-loading
branch
from
455074f
to
a7d7871
Compare
noisekit
force-pushed
the
fix/pools-loading
branch
from
a7d7871
to
36f8220
Compare
noisekit
force-pushed
the
fix/pools-loading
branch
from
a92676a
to
1a8cba2
Compare
noisekit
approved these changes
Nov 26, 2024
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.