admin profile test #427
Open
admin profile test #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue with the test, with one of the test imports not being imported in right now |
|
There isn't any admin/profile endpoint, so wouldn't this test be the same for regular /profile and this admin/profile? Also, it says content does not match, but it should be a compare json I think. |
|
This is testing to see if the profile endpoint works for an admin rather than a regular user. See the issue, I noted the differences at the top. If you want me to not compare certain fields, I can remove them. But the one's that didn't match seemed important. Also it is comparing json, I updated the compare funcs so check the comparison_type field on tests to see if it is json or json list. If the field is not there it is a regular text comparison. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #418