-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
login with no email #409
base: main
Are you sure you want to change the base?
login with no email #409
Conversation
This is kind of working. The test is submitting an email of "bademail", which doesn't fit into the regex of a valid email. Therefore, I currently have it written as a 400 error returning "Please enter a valid e-mail address". I feel this is a better response than the one in SBH1 which is a 401 stating "Your e-mail address was not recognized." |
Agreed. The message could be better. |
While I've approved, please fix the message and conflicts before merging. |
@anjalakaturi Please update the test to use a valid email address which is not a valid user. In this case, the message should match SB1. |
I just tested this on my local and I got the matching content. Not sure what the issue is, but will look into it more. |
closes #408